deps: upgrade PyO3 to 0.21 #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjrh
commented
May 5, 2024
cjrh
commented
May 5, 2024
cjrh
commented
May 5, 2024
cjrh
commented
May 5, 2024
cjrh
commented
May 5, 2024
cjrh
commented
May 5, 2024
cjrh
commented
May 5, 2024
cjrh
commented
May 5, 2024
cjrh
commented
May 5, 2024
adamreichold
reviewed
May 5, 2024
|
Huge thanks @adamreichold for your suggestions. I think this is much better now. I would appreciate another spot check to see if everything looks right? |
adamreichold
reviewed
May 7, 2024
adamreichold
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change upgrades PyO3 to 0.21, which introduces a new API for python object references. The following references have more information:
I don't have a super detailed understanding of the upstream changes in PyO3 0.21, but I played whack-a-mole with the compiler and the tests appear to pass. I've pointed out specific areas in the PR where I am unsure.