-
Notifications
You must be signed in to change notification settings - Fork 75
Add python release build #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So what this does is adds SHAs as the github actions which is one of the steps the open security foundation. I used https://app.stepsecurity.io/ for this as this is the recommended approach by openssf. The other thing this does is add a publish step on workflow dispatch, so manual run. We can change it to be based on tags if you wish |
Thank you! let me see if I can find someone to review this |
Re action locking, I’d rather see use of open source for security purposes.. https://github.com/sethvargo/ratchet is one such alternative. Use of such tool should be in its own pr, no commingled. It also avoids polluting every single job with extraneous steps. I’ll also note while it is a good practice, it is very rare in the wild to see action locking. |
It feels odd doing automation on a single old version of python on a single set of architecture, ideally this would be a matrix build with arch support for at least x86_64 and aarch64 |
could you clarify where you see/found this recommendation?, the only reference I can find to it, is a pr announce from step security itself. |
https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies |
@wallies is this PR good to go ? |
@Sidhant29 no needs to pull across changes from Kapiche fork |
Lgtm, the tooling on step security is both helpful and easily replaced.
…On Sat, Mar 18, 2023 at 6:59 PM Cameron ***@***.***> wrote:
@Sidhant29 <https://github.com/Sidhant29> no needs to pull across changes
from Kapiche fork
—
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFJEVZI4I4UVPHMUBZWH3W4Y45RANCNFSM55ZT6K2A>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
You have successfully added a new CodeQL configuration |
…kwit-oss#57) Bumps [messense/maturin-action](https://github.com/messense/maturin-action) from 1.36.0 to 1.37.2. - [Release notes](https://github.com/messense/maturin-action/releases) - [Commits](PyO3/maturin-action@7c85798...59e476b) --- updated-dependencies: - dependency-name: messense/maturin-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
No description provided.