Event types registered twice QT6

[nvrWhere]

Describe the bug
When trying to build neochat and hence libquotient with QT6 the resulting build is successful but the eventCast function always fails due to the eventType getting registered twice (see below for log on start)

quotient.events: "" -> RoomEvent; 1 derived type(s) registered for Event
quotient.events: "json.contains('state_key')" -> StateEvent; 1 derived type(s) registered for RoomEvent
quotient.events: "m.room.member" -> RoomMemberEvent; 1 derived type(s) registered for StateEvent
quotient.events: "m.room.message" -> RoomMessageEvent; 2 derived type(s) registered for RoomEvent
quotient.events: "m.tag" -> TagEvent; 2 derived type(s) registered for Event
quotient.events: "m.fully_read" -> ReadMarkerEventImpl; 3 derived type(s) registered for Event
quotient.events: "m.ignored_user_list" -> IgnoredUsersEventImpl; 4 derived type(s) registered for Event
quotient.events: "m.key.*" -> KeyVerificationEvent; 5 derived type(s) registered for Event
quotient.events: "m.key.verification.request" -> KeyVerificationRequestEvent; 1 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.ready" -> KeyVerificationReadyEvent; 2 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.start" -> KeyVerificationStartEvent; 3 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.accept" -> KeyVerificationAcceptEvent; 4 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.cancel" -> KeyVerificationCancelEvent; 5 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.key" -> KeyVerificationKeyEvent; 6 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.mac" -> KeyVerificationMacEvent; 7 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.done" -> KeyVerificationDoneEvent; 8 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.call.*" -> CallEvent; 3 derived type(s) registered for RoomEvent
quotient.events: "m.call.invite" -> CallInviteEvent; 1 derived type(s) registered for CallEvent
quotient.events: "m.call.candidates" -> CallCandidatesEvent; 2 derived type(s) registered for CallEvent
quotient.events: "m.call.answer" -> CallAnswerEvent; 3 derived type(s) registered for CallEvent
quotient.events: "m.call.hangup" -> CallHangupEvent; 4 derived type(s) registered for CallEvent
quotient.events: "m.room.encrypted" -> EncryptedEvent; 4 derived type(s) registered for RoomEvent
quotient.events: "m.dummy" -> DummyEvent; 6 derived type(s) registered for Event
quotient.events: "m.room_key" -> RoomKeyEvent; 7 derived type(s) registered for Event
quotient.events: "m.room.create" -> RoomCreateEvent; 2 derived type(s) registered for StateEvent
quotient.events: "m.room.tombstone" -> RoomTombstoneEvent; 3 derived type(s) registered for StateEvent
quotient.events: "m.direct" -> DirectChatEvent; 8 derived type(s) registered for Event
quotient.events: "m.room.encryption" -> EncryptionEvent; 4 derived type(s) registered for StateEvent
quotient.events: "m.reaction" -> ReactionEvent; 5 derived type(s) registered for RoomEvent
quotient.events: "m.receipt" -> ReceiptEvent; 9 derived type(s) registered for Event
quotient.events: "m.room.redaction" -> RedactionEvent; 6 derived type(s) registered for RoomEvent
quotient.events: "m.room.avatar" -> RoomAvatarEvent; 5 derived type(s) registered for StateEvent
quotient.events: "m.room.canonical_alias" -> RoomCanonicalAliasEvent; 6 derived type(s) registered for StateEvent
quotient.events: "m.room.power_levels" -> RoomPowerLevelsEvent; 7 derived type(s) registered for StateEvent
quotient.events: "m.room.name" -> RoomNameEvent; 8 derived type(s) registered for StateEvent
quotient.events: "m.room.topic" -> RoomTopicEvent; 9 derived type(s) registered for StateEvent
quotient.events: "m.room.pinned_events" -> RoomPinnedEventsEvent; 10 derived type(s) registered for StateEvent
quotient.events: "m.room.aliases" -> RoomAliasesEvent; 11 derived type(s) registered for StateEvent
quotient.events: "m.typing" -> TypingEvent; 10 derived type(s) registered for Event
quotient.events: "m.key.*" -> KeyVerificationEvent; 1 derived type(s) registered for Event
quotient.events: "m.key.verification.request" -> KeyVerificationRequestEvent; 1 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.ready" -> KeyVerificationReadyEvent; 2 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.start" -> KeyVerificationStartEvent; 3 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.accept" -> KeyVerificationAcceptEvent; 4 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.cancel" -> KeyVerificationCancelEvent; 5 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.key" -> KeyVerificationKeyEvent; 6 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.mac" -> KeyVerificationMacEvent; 7 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.key.verification.done" -> KeyVerificationDoneEvent; 8 derived type(s) registered for KeyVerificationEvent
quotient.events: "m.tag" -> TagEvent; 2 derived type(s) registered for Event
quotient.events: "m.fully_read" -> ReadMarkerEventImpl; 3 derived type(s) registered for Event
quotient.events: "m.ignored_user_list" -> IgnoredUsersEventImpl; 4 derived type(s) registered for Event
quotient.events: "" -> RoomEvent; 5 derived type(s) registered for Event
quotient.events: "json.contains('state_key')" -> StateEvent; 1 derived type(s) registered for RoomEvent
quotient.events: "m.call.*" -> CallEvent; 2 derived type(s) registered for RoomEvent
quotient.events: "m.call.invite" -> CallInviteEvent; 1 derived type(s) registered for CallEvent
quotient.events: "m.call.candidates" -> CallCandidatesEvent; 2 derived type(s) registered for CallEvent
quotient.events: "m.call.answer" -> CallAnswerEvent; 3 derived type(s) registered for CallEvent
quotient.events: "m.call.hangup" -> CallHangupEvent; 4 derived type(s) registered for CallEvent
quotient.events: "m.room.encrypted" -> EncryptedEvent; 3 derived type(s) registered for RoomEvent
quotient.events: "m.dummy" -> DummyEvent; 6 derived type(s) registered for Event
quotient.events: "m.room_key" -> RoomKeyEvent; 7 derived type(s) registered for Event
quotient.events: "m.room.message" -> RoomMessageEvent; 4 derived type(s) registered for RoomEvent
quotient.events: "m.room.create" -> RoomCreateEvent; 1 derived type(s) registered for StateEvent
quotient.events: "m.room.tombstone" -> RoomTombstoneEvent; 2 derived type(s) registered for StateEvent
quotient.events: "im.ponies.room_emotes" -> ImagePackEvent; 3 derived type(s) registered for StateEvent
quotient.events: "m.room.member" -> RoomMemberEvent; 4 derived type(s) registered for StateEvent
quotient.events: "m.reaction" -> ReactionEvent; 5 derived type(s) registered for RoomEvent
quotient.events: "m.room.redaction" -> RedactionEvent; 6 derived type(s) registered for RoomEvent
quotient.events: "m.room.avatar" -> RoomAvatarEvent; 5 derived type(s) registered for StateEvent
quotient.events: "m.room.name" -> RoomNameEvent; 6 derived type(s) registered for StateEvent
quotient.events: "m.room.topic" -> RoomTopicEvent; 7 derived type(s) registered for StateEvent
quotient.events: "m.room.pinned_events" -> RoomPinnedEventsEvent; 8 derived type(s) registered for StateEvent
quotient.events: "m.room.aliases" -> RoomAliasesEvent; 9 derived type(s) registered for StateEvent
quotient.events: "org.matrix.msc3381.poll.start" -> PollStartEvent; 7 derived type(s) registered for RoomEvent
quotient.events: "org.matrix.msc3381.poll.response" -> PollResponseEvent; 8 derived type(s) registered for RoomEvent
quotient.events: "org.matrix.msc3381.poll.end" -> PollEndEvent; 9 derived type(s) registered for RoomEvent
quotient.events: "m.sticker" -> StickerEvent; 10 derived type(s) registered for RoomEvent
quotient.events: "m.room.encryption" -> EncryptionEvent; 10 derived type(s) registered for StateEvent
quotient.events: "m.room.canonical_alias" -> RoomCanonicalAliasEvent; 11 derived type(s) registered for StateEvent
quotient.events: "m.room.power_levels" -> RoomPowerLevelsEvent; 12 derived type(s) registered for StateEvent
quotient.events: "m.room.join_rules" -> JoinRulesEvent; 13 derived type(s) registered for StateEvent

To Reproduce
Steps to reproduce the behaviour, and the description of the actual result:

1. Using kdesrc-build with KF6 config file build neochat and all dependencies
2. Launch with quotient.events.debug=true
3. See all the eventtypes get registered twice in the log

Expected behavior
event types are only registered once and all functionality depending on eventCast works

Is it environment-specific?
kdesrc-build used as the toolchain
cmake-options -DBUILD_SHARED_LIBS=ON -DBUILD_WITH_QT6=ON -DQuotient_ENABLE_E2EE=on
branch dev
arch linux

[KitsuneRal]

For the record - this seems to be specific to the compiler/compiler flags. Quotient 0.9 will change the mechanism to register event types to rely less on symbol preempting across shared objects.

[KitsuneRal]

For the record - I just found that there might be an issue with CMakeLists.txt files not being in perfect harmony somewhere, as I discovered a pile of complaints about possibly different visibility settings on macOS (see, e.g., here, step 'Build and install Quaternion'). In this particular case it was Quaternion but the problem may be common to both clients.

[KitsuneRal]

Just a shot in the dark of sorts - can you try to add something like

set_target_properties(neochat PROPERTIES
    VISIBILITY_INLINES_HIDDEN ON
    CXX_VISIBILITY_PRESET hidden
)

to src/CMakeLists.txt and see if that helps? As I understand it, normally that's something enforced by ECM macros but just in case...

[KitsuneRal]

...and just as I wrote this I realised that it's exactly -fvisibility=hidden -fvisibility-inlines-hidden that I've seen in compile_commands.json you shared separately. Sorry for the noise.

[nvrWhere]

Yeah I gave it try and no luck oh well

[tcanabrava]

More information about this bug can be seen here - as I had the same problem:
https://invent.kde.org/network/neochat/-/merge_requests/1326

I would like to help figuring out & fixing this - I'll try over the weekend.

[KitsuneRal]

This seems to be the culprit: https://invent.kde.org/network/neochat/-/merge_requests/1326#note_883654

[KitsuneRal]

Independently, while trying to figure out the consequences of -mno-direct-extern-access I found an article about protected symbols that explains them in a somewhat simpler language (that I can understand at least). Combined with the pointer from Antonio, makes it pretty clear what's going on.