Add a promise/future pair to PendingEventItem #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically very similar to postEvent(), post() takes ownership guarantees to the type system, and returns a reference to the pending event item that is produced in the process of posting anyway and has all the information in a single structure including the transaction id that is returned now - instead of the sole transaction id which is frequently only used to find the pending event item first thing. The template overload of post() also allows to construct an event on the fly instead of creating an event object upfront (see the corresponding change in quotest.cpp). Other post*() methods still return transaction id in order to retain interoperability with QML. I haven't seen Quaternion or NeoChat actually using the returned values from post*() calls though. We might eventually move on to some Q_GADGET wrapper of PendingEventItem so that post*() methods could still be fully interoperable with QML but provide more information that a mere transaction id - if needed.
|
|
@TobiasFella what do you think of switching to |
should be fine for us |
|
looks reasonable, will test later |
TobiasFella
previously approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PendingEventItemscreams that it has semantics of a future even with its name - now one can obtain a future from it and do useful things inthen(), instead of connecting topendingEvent*signals. The downside - the future carries no information about the pending item index so it seems of limited use in event item models.