Another round of cleanup #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because sometimes you want to do stuff on assertion passage rather than failure. QUO_CHECK is still different from Q_ASSERT: like QUO_ALARM[_X], it always evaluates the expression passed to it, even in Release builds.
Inspired by C++26 changes to assert() - see https://en.cppreference.com/w/cpp/error/assert for details.
KitsuneRal
added
bug/fix
TobiasFella
reviewed
Aug 24, 2024
TobiasFella
previously approved these changes
Aug 24, 2024
|
The two are almost always set together, except the mock case.
See the Qt bug reference in the code.
The Qt project moves to std:: compatible APIs in its own code (e.g. see https://github.com/qt/qtbase/commit/ c5f3c61469517a4ac00e4da01fe0bab9188c1488) and we don't have that many occurrences of synonym functions by now, so let's clean this up.
This was omitted during the review of #784.
KitsuneRal
force-pushed
the
kitsune/another-cleanup
branch
from
5e9b898 to
6da0236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All very straightforward but best reviewed commit by commit.