which_r version R version choice validation

[iaine]

When I use which_r in the devel branch on codespace and choose R, I can enter incorrect numbers without it being caught.

I would expect if choosing a value higher than the environments to have a warning. Maybe a simple add an else to the blocks in lines 36 - 40:
'''
if [[ ! "$choice" =~ ^[1-9]$ ]]; then
echo "Invalid choice. Please enter a number between 1 and $(($counter - 1))"
exit 1
elif [[ "$choice" > $counter ]]; then
echo "Invalid choice. Please enter a number between 1 and $(($counter - 1))"
exit 1
fi
'''
?

Otherwise the script returns with a path to an R` that does not exist.

[StarTrooper08]

Thanks! yeah we need to add this to handle the error properly.

I think we can shift the R version to default R if user enters outside of the options. And rerun the script for user to change R console version.

[hturner]

Also note the range is incorrect if you enter an invalid choice when there is only one option:

@hturner ➜ /workspaces/r-dev-env $ which_r
Which version of R should be used in new R terminals?
  1. R 4.4.0 (release version built into this container)
Enter the number corresponding to the selected version: 0
Invalid choice. Please enter a number between 1 and -1
``

[iaine]

The script now assigns to the system R if an invalid number is given.

[iaine]

When I use a blank container without building r and use which_r and enter 3, I still see:
Invalid choice, plese select options between 1 to -1.

It seems to be linked to line 48 in which_r where range=$((counter - 1)) is set. If counter is 1 you get -1. Can counter be set to 1, rather than 2 as in line 19 as it appears to be incremented when looking at paths?