Skip to content

Support trailing slash in install_dev() #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2022
Merged

Support trailing slash in install_dev() #692

merged 3 commits into from
Jan 26, 2022

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 25, 2022

to support units and sf.

Should we extract the parse code and add tests?

gaborcsardi
gaborcsardi reviewed Jan 25, 2022
View reviewed changes
@krlmlr krlmlr requested a review from gaborcsardi January 26, 2022 16:41
@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi gaborcsardi merged commit 9355549 into main Jan 26, 2022
@gaborcsardi gaborcsardi deleted the b-trailing-slash branch January 26, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi Awaiting requested review from gaborcsardi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @gaborcsardi