Drop support for Xcode15 #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes legacy conditional code branches and tests related to Xcode15 support, streamlining the codebase for the updated compiler and tooling requirements. The key changes include:
- Removal of #if/#else conditional branches designed for older compiler versions.
- Deletion of backward compatibility tests and CI jobs for Xcode15.
- Updates to documentation and configuration files to reflect the dropped support.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/AtomsTests/Utilities/Utilities.swift | Removed the older yield implementation branch for pre‑Xcode16. |
| Tests/AtomsTests/Utilities/TestAtom.swift | Eliminated alternate value() implementations for older compilers. |
| Tests/AtomsTests/Core/StoreContextTests.swift | Removed conditional code blocks for legacy compiler support. |
| Tests/AtomsTests/BackwardCompatibilityTests.swift | Deleted entire file as Xcode15 support is dropped. |
| Tests/AtomsTests/Atom/AsyncPhaseAtomTests.swift | Removed legacy assertions for pre‑Xcode16 behavior. |
| Sources/Atoms/* (various files) | Updated conditional compilation directives reflecting new support. |
| README.md | Adjusted requirements table to show new language mode settings. |
| [email protected] | Removed support file for the now‑unsupported Swift 5 package. |
| .github/workflows/test.yml | Dropped CI configurations testing with Xcode15. |
Comments suppressed due to low confidence (2)
Tests/AtomsTests/Utilities/Utilities.swift:150
- [nitpick] The removal of the legacy alternative for Task.yield appears consistent with dropping Xcode15 support; please verify that the updated implementation fully meets the concurrency guarantees on supported platforms.
await yield()
.github/workflows/test.yml:14
- [nitpick] With the removal of Xcode15 CI jobs, ensure that the remaining tests provide sufficient coverage for scenarios that were previously validated on Xcode15.
IOS_SIMULATOR_XCODE_15: '"platform=iOS Simulator,name=iPhone 15 Pro"'
| |watchOS|7.0 | | ||
| | |Minimum Version| | ||
| |------------:|--------------:| | ||
| |Language mode|5, 6 | |
There was a problem hiding this comment.
[nitpick] The updated requirements table omits explicit Xcode version details; consider adding a note to clearly state that support for Xcode15 has been dropped.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type