Allow multi namespace cache scoping#1341
Merged
Zerpet merged 1 commit intorabbitmq:mainfrom May 3, 2023
Merged
Conversation
Member
|
Verified the new behaviour, working as expected. I did the following:
|
Zerpet
approved these changes
May 3, 2023
Member
|
The CI failure seems unrelated to this PR. I suspect it is failing because the PR is coming from a fork, and GitHub Secrets are not injected in forks, based on this message:
|
Zerpet
added a commit
to rabbitmq/rabbitmq-website
that referenced
this pull request
May 8, 2023
- Document feature introduced by rabbitmq/cluster-operator/pull/1341 - Formatting to avoid long lines. No effect on rendering - Document missing variables related to leader electio Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Allows scoping the cache namespace to more than 1 namespace if
OPERATOR_SCOPE_NAMESPACEis a comma delimited list.Additional Context
If someone needed to configure their RBAC with non-cluster
rolesandrolebindingsthey would be unable to run the operator. This project requires access to a lot of resources and not everyone's security stance allows for usingclusterroles.Without providing
OPERATOR_SCOPE_NAMESPACEand usingroleinstead ofclusterroleyou get errors such asand a similar error if a resource is added in a namespace not covered by
OPERATOR_SCOPE_NAMESPACE.Without this change, it's only possible to scope the cache to a single namespace, and this allows for scoping to a list of namespaces.
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny: