Fix x86 assembler accepting invalid register names like r1 ##asm#25183
Merged
trufae merged 1 commit intoradareorg:masterfrom Jan 7, 2026
Merged
Conversation
trufae
reviewed
Jan 7, 2026
The parseReg() function in x86_nz assembler used r_str_ncasecmp() with only the input token length, causing prefix matching. For example, 'r1' (length=2) would match the first 2 characters of 'r10', producing incorrect machine code. Fix by adding strlen() check to ensure the register name length matches the token length exactly before comparing. Fixes radareorg#25036
0verflowme
force-pushed
the
fix/issue-25036-x86-invalid-register
branch
from
d45fd9d to
5073377
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parseReg() function in x86_nz assembler used r_str_ncasecmp() with only the input token length, causing prefix matching. For example, 'r1' (length=2) would match the first 2 characters of 'r10', producing incorrect machine code.
Fix by adding strlen() check to ensure the register name length matches the token length exactly before comparing.
Fixes #25036
Description