Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for otezip as an alternative to libzip for handling ZIP archives in radare2. The integration provides both Meson and Makefile build system support with a new use_otezip configuration option.
- Adds otezip subproject integration via wrap files for dependency management
- Introduces a new build option
use_otezipto toggle between traditional libzip and otezip - Updates build logic in both Meson and Makefile systems to support the new library
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| subprojects/otezip.wrap | Defines otezip as a git subproject at version 0.3.2 |
| subprojects/otezip.mk | Makefile logic for cloning and building the otezip subproject |
| shlr/zip/meson.build | Adds conditional build logic to use otezip when enabled, with fallback paths |
| shlr/zip/Makefile | Adds Makefile support for building with otezip instead of libzip |
| meson_options.txt | Adds the use_otezip boolean option for build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
trufae
force-pushed
the
otezip0+
branch
2 times, most recently
from
5623f7f to
b9091f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description