Skip to content

fix(cli): validate --exclude regex pattern before use #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafaeltonholo merged 2 commits into from
Mar 28, 2026
Merged

fix(cli): validate --exclude regex pattern before use #251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc3e04a
fix(cli): validate --exclude regex pattern before use
mvanhorn Mar 27, 2026
32f89fb
fix(cli): catch IllegalArgumentException instead of generic Exception
mvanhorn Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion svg-to-compose/src/nativeMain/kotlin/Main.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import com.github.ajalt.clikt.parameters.options.help
import com.github.ajalt.clikt.parameters.options.option
import com.github.ajalt.clikt.parameters.options.pair
import com.github.ajalt.clikt.parameters.options.required
import com.github.ajalt.clikt.parameters.options.validate
import com.github.ajalt.clikt.parameters.types.boolean
import com.github.ajalt.clikt.parameters.types.choice
import com.github.ajalt.clikt.parameters.types.int
Expand Down Expand Up @@ -147,7 +148,13 @@ class Client : CliktCommand(name = "s2c") {
private val exclude by option(
names = arrayOf("--exclude"),
help = "A regex used to exclude some icons from the parsing.",
)
).validate { pattern ->
try {
Regex(pattern)
} catch (e: IllegalArgumentException) {
fail("Invalid regex pattern: \"$pattern\". ${e.message}")
}
}

private val indentSize by option(
names = arrayOf("--indent-size"),
Expand Down
Loading