Fix path parsing not considering scientific notation

[rafaeltonholo]

This pr addresses issue #56 where the path normalization was not considering scientific notation values.

Summary by CodeRabbit

• New Features

  • Improved parsing logic for SVG transformation strings, enhancing flexibility and robustness.

• Bug Fixes

  • Enhanced error handling for string-to-float conversions in SVG transformations, providing clearer feedback on parsing issues.

• Chores

  • Updated .gitignore to exclude specific SVG files related to GitHub issues, streamlining file management in the repository.

[coderabbitai]

Walkthrough

The changes introduced in this update primarily focus on enhancing file management and improving the robustness of SVG handling in the codebase. A new entry in the .gitignore file prevents tracking of SVG files related to GitHub issues, streamlining the repository. In the Kotlin code, the normalizePath function sees refined logic for character processing, while the parsing logic in SvgTransform.kt is enhanced with better error handling and flexible input parsing for SVG transformations.

Changes

File Path	Change Summary
.gitignore	Added entry to ignore files named github_issue_[0-9]*.svg to improve file management.
svg-to-compose/src/commonMain/kotlin/dev/.../ImageVectorNode.kt	Refined logic in normalizePath for better character handling, renaming of variables for clarity.
svg-to-compose/src/commonMain/kotlin/dev/.../SvgTransform.kt	Enhanced SVG transformation parsing with additional delimiters and improved error handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Git
    participant SVGParser
    
    User->>Git: Commits changes
    Git->>Git: Ignores `github_issue_[0-9]*.svg`
    
    User->>SVGParser: Sends SVG transformation string
    SVGParser->>SVGParser: Parses string with improved delimiters
    SVGParser->>SVGParser: Attempts to convert substrings to float
    SVGParser-->>User: Returns parsed result or error

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5af260c and 31beb88.

Files selected for processing (3)

• .gitignore (1 hunks)
• svg-to-compose/src/commonMain/kotlin/dev/tonholo/s2c/domain/ImageVectorNode.kt (2 hunks)
• svg-to-compose/src/commonMain/kotlin/dev/tonholo/s2c/domain/svg/transform/SvgTransform.kt (1 hunks)

Files skipped from review due to trivial changes (1)

• .gitignore

Additional comments not posted (3)

svg-to-compose/src/commonMain/kotlin/dev/tonholo/s2c/domain/svg/transform/SvgTransform.kt (1)

57-62: Robust parsing and error handling improvements.

The addition of the extra delimiter and the use of toFloatOrNull with requireNotNull enhances the robustness of the parsing logic. This change ensures better handling of various input formats and provides informative error messages.

svg-to-compose/src/commonMain/kotlin/dev/tonholo/s2c/domain/ImageVectorNode.kt (2)

491-493: Improved variable naming for clarity.

The introduction of isNotENotation and the renaming of isNegativeSign to isNegativeSignSeparator enhance the readability and clarity of the code, making the logic more understandable.

---

Line range hint 510-516: Enhanced handling of scientific notation.

The refined logic for appending characters ensures that scientific notation is correctly parsed, improving the accuracy of path normalization.