Remove setting RAILS_ENV from RACK_ENV, NODE_ENV defaults RAILS_ENV (#3239)

* Remove setting RAILS_ENV from RACK_ENV

Per #3200

* Have NODE_ENV default to RAILS_ENV

Author: justin808

lib/install/bin/webpack

@@ -5,8 +5,8 @@ require "bundler/setup"
 require "webpacker"
 require "webpacker/webpack_runner"
 
-ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
-ENV["NODE_ENV"]  ||= "development"
+ENV["RAILS_ENV"] ||= "development"
+ENV["NODE_ENV"]  ||= ENV["RAILS_ENV"]
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", Pathname.new(__FILE__).realpath)
 
 APP_ROOT = File.expand_path("..", __dir__)

lib/install/bin/webpack-dev-server

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
-ENV["NODE_ENV"]  ||= "development"
+ENV["RAILS_ENV"] ||= "development"
+ENV["NODE_ENV"]  ||= ENV["RAILS_ENV"]
 
 require "pathname"
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",

test/test_app/bin/webpack

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
+ENV["RAILS_ENV"] ||= "development"
 ENV["NODE_ENV"] ||= ENV["RAILS_ENV"]
 
 require "pathname"

test/test_app/bin/webpack-dev-server

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
+ENV["RAILS_ENV"] ||= "development"
 ENV["NODE_ENV"] ||= ENV["RAILS_ENV"]
 
 require "pathname"