Remove setting RAILS_ENV from RACK_ENV, NODE_ENV defaults RAILS_ENV #3239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
force-pushed
the
remove-rack-env
branch
from
4fcd610 to
dee7e55
Compare
justin808
changed the title
|
This is great, maybe we should talk about |
@guillaumebriday where in the docs? |
justin808
added a commit
to justin808/rails
that referenced
this pull request
Jan 6, 2022
environment configures the Rack env. This may not match different Rails environments. rails/webpacker#3200 rails/webpacker#3239 This matches the Heroku docs: https://devcenter.heroku.com/articles/deploying-rails-applications-with-the-puma-web-server#environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://nodejs.dev/learn/nodejs-the-difference-between-development-and-production
Generally, the only value that matters for NODE_ENV is production.
Given the old code, I suspect that many people ranrake assets:precompileand had the NODE_ENV incorrectly set to 'development' for production builds.Actually, for running the rake task to build, https://github.com/rails/webpacker/blob/master/lib/tasks/webpacker/compile.rake#L23 sets the NODE_ENV to production if not set.