[webpacker 6.0.0.rc.5] stylesheet_pack_tag doesn't work with HMR

[pustovalov]

// webpacker.yml

hmr: false

// webpacker.yml

hmr: true

Demo repo:
https://github.com/pustovalov/webpacker-hmr-reproduce

[guillaumebriday]

Could you take a look @justin808 please?

[justin808]

Should we close this one?

I don't see any documentation of the issue above.

[justin808]

Seems like a misunderstanding that HMR page should have the CSS on the HTML. It just shouldn't.

[pustovalov]

Should we close this one?

Need to describe it in the documentation at least. Webpacker v6 doesn't support HMR and CSS outside of JS together. Because this combination worked good in Webpacker v5.

[justin808]

@pustovalov I think this should be closed. We've got support for CSS with HMR.

For React, here's the configuration for HMR.

#3224

[pustovalov]

We've got support for CSS with HMR.

@justin808 where was this support added? stylesheet_pack_tag still returns nil:

webpacker/lib/webpacker/helper.rb

Line 144 in 2f4df42

return "" if Webpacker.inlining_css?

[justin808]

It's supposed to return blank if that value is true.

Just setup your webpscker config so that value is false.