[v0.14] - Adds support for Helm lookup #4380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds support for Helm lookup Adds support for using templates with the _lookup_ command from _Helm_ as it was previously not working because of the first run that we do for the _install_ command we do it in _dryRun_ mode to check for errors. In that case the Helm command internally was not doing the call to the cluster and the _lookup_ calls where resolving to `nil`. This PR adds a new function that checks if a given _Chart_ has templates with the _lookup_ command and, if so, it enables the `DryRunOption="server"` and also sets the option `ClientOnly` to _false_ so Helm connects the cluster and the _lookup_ does not return `nil` Refers to: rancher#1851 --------- Signed-off-by: Xavi Garcia <[email protected]>
weyfonk
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #4379
Backport of: #1851
Additional Information
Checklist
- [ ] I have updated the documentation via a pull request in thefleet-docs repository.