Skip to content

Conversation

@0xavi0
Copy link
Contributor

@0xavi0 0xavi0 commented Nov 28, 2025

Backports #4319, fixing the following:

When calling the gitcloner it was sometimes returning the following error:

gitcloner-initializer {"fleetErrorMessage":"failed to clone repo from branch repo=\"https://fleet-ci/:[email protected].
 local:4343/repo\" branch=\"master\" revision=\"\" path=\"/workspace\": Get \"https://fleet-ci/:***@git-service.default.svc.cluster.local:4 
 343/repo/info/refs?service=git-upload-pack\": tls: failed to verify certificate: x509: certificate signed by unknown authority","level":" 
 fatal","msg":"Fleet cli failed","time":"2025-11-28T11:10:59Z"}

I've tested running the e2e tests with --until-it-fails locally.
I've also tried the same on main and it didn't fail.

@0xavi0 0xavi0 self-assigned this Nov 28, 2025
@0xavi0 0xavi0 added the area/ci label Nov 28, 2025
@0xavi0 0xavi0 marked this pull request as ready for review November 28, 2025 13:42
@0xavi0 0xavi0 requested a review from a team as a code owner November 28, 2025 13:42
@0xavi0 0xavi0 marked this pull request as draft November 28, 2025 14:27
@0xavi0 0xavi0 marked this pull request as ready for review November 28, 2025 16:28
@0xavi0 0xavi0 requested a review from weyfonk November 28, 2025 16:29
@weyfonk weyfonk changed the title [v0.14] - Fix failing e2e test [v0.14] - Fix race when creating secrets and Kubernetes jobs Nov 28, 2025
@weyfonk weyfonk added this to Fleet Nov 28, 2025
@weyfonk weyfonk removed this from Fleet Nov 28, 2025
@weyfonk weyfonk added this to Fleet Nov 28, 2025
@weyfonk weyfonk moved this to 👀 In review in Fleet Nov 28, 2025
@weyfonk weyfonk added this to the v2.13.1 milestone Nov 28, 2025
0xavi0 and others added 2 commits November 28, 2025 17:36
Signed-off-by: Xavi Garcia <[email protected]>
* Fix race when creating secrets and Kubernetes jobs

When creating secrets and a Kubernetes Job that uses those secrets in
volumes, it is possible that the job is created before the secret has
been synchronized. If the job required the content of the secret to be
mounted, the file would be missing.

Also fixes usage of `controllerutil.CreateOrUpdate`.

* Apply suggestion from @weyfonk

Co-authored-by: Corentin Néau <[email protected]>

---------

Co-authored-by: Corentin Néau <[email protected]>
@weyfonk weyfonk force-pushed the 0.14-fix-failing-e2e-test branch from d0131f3 to aa5376e Compare November 28, 2025 16:37
@weyfonk weyfonk enabled auto-merge (squash) November 28, 2025 16:38
@weyfonk weyfonk merged commit 39f263b into rancher:release/v0.14 Nov 28, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Fleet Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants