[0.14] Create options secret before bundle deployment #4393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xavi0
approved these changes
Dec 1, 2025
* Create options secret before bundle deployment Based on an idea from rancher#3889 by Alejandro Ruiz, the bundle controller now creates an options secret, if such a secret is needed, before the bundle deployment which will end up owning it. This should prevent some errors about missing secrets. * Optimise owner reference setting on options secret Setting an owner reference pointing to a bundle deployment on its options secret can be done when creating or updating the secret, if the bundle deployment already exists. This works even if the bundle deployment is outdated, to be subsequently updated, because its UID is immutable. This could save the bundle controller a few separate secret update requests when repeatedly updating multiple bundle deployments. --------- Co-authored-by: Alejandro Ruiz <[email protected]>
weyfonk
force-pushed
the
0.14-create-options-secret-before-bd
branch
from
999cbfa to
5a69b54
Compare
0xavi0
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4284 to v0.14.
Additional Information
Checklist
- [ ] I have updated the documentation via a pull request in thefleet-docs repository.