Make valuesFrom kind check case-insensitive #4408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavi Garcia <[email protected]>
0xavi0
added a commit
to 0xavi0/fleet
that referenced
this pull request
Dec 9, 2025
Signed-off-by: Xavi Garcia <[email protected]>
thardeck
pushed a commit
that referenced
this pull request
Dec 9, 2025
Signed-off-by: Xavi Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be case-insensitive for the resource Kind when checking if it is in the list of resources that are copied downstream, since in the original functionality they are ignored.
This was found by QA when testing #4378, so it should be considered a follow-up
Refers to #4274
Additional Information
Checklist
- [ ] I have updated the documentation via a pull request in thefleet-docs repository.