[v0.14] Preserve cloned secret type #4496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyfonk
force-pushed
the
0.14-preserve-cloned-secret-type
branch
2 times, most recently
from
93257e7 to
b9b725b
Compare
Contributor
|
See the code review in the PR targeting |
0xavi0
approved these changes
Jan 9, 2026
weyfonk
force-pushed
the
0.14-preserve-cloned-secret-type
branch
2 times, most recently
from
c890850 to
2438dc5
Compare
When automatically copying secrets to downstream clusters, Fleet would previously not preserving their type. This is now fixed, allowing image pull secrets not to be copied with type `Opaque` anymore, and hence enabling those image pull secrets to be detected as such by Helm.
The bundle controller itself now preserves the source secret type, if no overridden secret type is provided.
A bundle deployment must be force-redeployed if at least one resource copied downstream has been updated.
The bundle controller must propagate a secret's type to the downstream cluster's namespace when updating the secret, not just when creating it.
weyfonk
force-pushed
the
0.14-preserve-cloned-secret-type
branch
from
2438dc5 to
07374cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4490 to v0.14.
Refers to #3617.
Requires #4497.
Additional Information
Checklist
- [ ] I have updated the documentation via a pull request in thefleet-docs repository.