[v0.14] - Prevent race when bundles are created concurrently #4503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and go-getter is used to clone an HTTPS git repository. (cherry picked from commit 948a7e9)
Co-authored-by: Corentin Néau <[email protected]> (cherry picked from commit 7e218f7)
Co-authored-by: Copilot <[email protected]> (cherry picked from commit 7bcad2f)
When cloning content with git over HTTPS with different settings, a race could still occur. By ensuring that every cloning with git over HTTPS, regardless the settings of all bundles, we ensure there isn't a race. This is actually suboptimal, as bundles with equal settings could theoretically be cloned concurrently. However, should the need for this actually arise, it would be cleaner and more maintainable to extend the functionality of go-getter than having to use locks for this functionality in our code at all. The lock still ensures that all other fetch operations of bundle creation (including fetch of content with go-getter that is using git over HTTPS) can run concurrently. (cherry picked from commit bd51100)
* Fix octal number interpretation in cache key calculation The date +%j format returns values with leading zeros (e.g., 008 for January 8th). Bash interprets numbers with leading zeros as octal in arithmetic expressions, causing an error since octal only supports digits 0-7. Use date +%-j instead to get the day of year without leading zeros, avoiding the octal interpretation issue. * Extract cache key logic to shared script Move the cache key determination logic to a reusable script to reduce redundancy across 7 workflow files. (cherry picked from commit fb55b29)
0xavi0
changed the title
weyfonk
approved these changes
Jan 8, 2026
weyfonk
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #4502
Additional Information
Checklist
fleet-docs repository.