Skip to content

Conversation

@thardeck
Copy link
Collaborator

@thardeck thardeck commented Jan 9, 2026

Replace the complex 28-day modulo logic with a year-month approach that rotates the cache 12 times per year.

Replace the complex 28-day modulo logic with a year-month approach that
rotates the cache 12 times per year.
@thardeck thardeck requested a review from aruiz14 January 9, 2026 05:42
@thardeck thardeck self-assigned this Jan 9, 2026
@thardeck thardeck requested a review from a team as a code owner January 9, 2026 05:42
@thardeck thardeck added this to Fleet Jan 9, 2026
Copilot AI review requested due to automatic review settings January 9, 2026 05:42
@thardeck thardeck moved this to 👀 In review in Fleet Jan 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the cache key determination logic by replacing a complex 28-day modulo-based rotation with a straightforward monthly (year-month) format. This provides more predictable cache behavior with 12 cache rotations per year instead of the previous irregular pattern.

Key changes:

  • Replaced day-of-year modulo logic with simple year-month date formatting
  • Updated comments to reflect the new monthly rotation approach
  • Removed conditional logic that alternated between date-based keys and "latest"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kkaempf kkaempf added this to the v2.14.0 milestone Jan 9, 2026
@thardeck thardeck merged commit 462590f into main Jan 9, 2026
40 of 42 checks passed
@thardeck thardeck deleted the improve_crust_gatherer_caching branch January 9, 2026 12:21
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Fleet Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants