Convert installer to go #1456

SvenDowideit · 2016-12-07T12:58:16Z

its alive. I'm hoping we can merge a version of this for rc2, and then refine afterwards, but idk - i've come across so many little corner cases already.

uses syslinux only,
installs a linux-current.cfg boot config, and
on upgrade, that will (not impled yet) be renamed to linux-previous.cfg and a new current cfg added
installer image is now alpine based
the iso contains an export of an installer base image that doesn't contain the vmlinux/initrd, besire the initrd
the installer tries to mount the bootiso, load the installer base, and then grab the bootiso's vmlinuz and initrd
GPT partitioning and booting - from GPT partition option #1448
integration-tests for the boot from iso, install, boot from HD -
also test running installer on a partitioned disk - make sure its not-destructive

for a later PR:

Raid tests and support - Install fails on raid1 (software) #1250
GPT using of state (its not mounting for >3TB disks)
EFI boot
see if we can log the vm output to disk, rather than to screen
update and test arm installer image
logging cleanup - atm, it shows too much, and then too little to the user

Note, there are commented out bits that will need to be deferred til 0.9 - changes are needed to how we build and package kernels

joshwget · 2016-12-09T00:36:51Z

os-config.tpl.yml

      - /usr/bin/iptables:/sbin/iptables:ro
      - /media:/media:shared
      - /mnt:/mnt:shared
+      - /:/host


Was this for debugging? Do we need this?

its used to get access to the /dev/vda1 partition that we create - udev works outside the container, but not inside

But isn't being run in the installer container and not the console? /dev in the console container should be the same as /dev on the host anyways.

sadly, its not the same - if there are changes to /dev in the host after the container is started, then those changes are not mirrored inside the container. and in this case, its udev making /dev/vda1 which we use inside.

And then when we look at RAID and custom partitions in 0.9, there'll be even more dynamics (same thing if we start to have other devices with loaded modules)

But don't we already bind mount /dev:/host/dev in the console container? Why do we need to bind mount in the entire root filesystem too?

oh crud. this isn't the host volume I thought it was - removing.

Not that it matters much for just the installer container, but you could probably bind mount /dev:/host/dev and run ros entrypoint as the entrypoint instead of /:/host.

SvenDowideit · 2016-12-15T04:36:22Z

wget https://raw.githubusercontent.com/RoastLink/roastlink.github.io/master/cloud-config.yml
sudo ros install -d /dev/vda -c cloud-config.yml --no-reboot --append rancher.password=rancher -t gptsyslinux -f 2>&1 | tee install.log

tylert · 2016-12-15T21:13:28Z

cmd/control/install.go

+		}
+	}
+
+	useIso := false


Silly question... If the mount and "system-docker load" lines below come after the "system-docker run" lines above, won't that prevent the os/installer image from being made available at the start of the "ros install" command?

the system-docker run commands above are when the user is requesting to install a version that is different to the one on the iso - so it will pull the image from the hub

Got it, thanks. In my horrible hack, I was blindly mounting and loading the os image since I knew that whatever I packed on my ISO was what I needed to keep the Vagrant users happy and because I was hacking my junk on top of 0.7.1 without all your other nice changes (yet). LGTM.

tylert · 2016-12-16T14:32:03Z

scripts/package

-if [ "$INSTALLER" != "0" ]; then
-    ./package-installer
-fi
+


I had to make the same change for my temporary workaround as well. Glad you did this too.

tylert · 2016-12-16T14:40:08Z

I didn't notice whether you were copying anything from the ISO into /var/lib/rancher/preload/{system-,}docker (if it exists) for these changes. Was this stuff part of your future plans/commits or not in scope?

For my own hack, I just ended up adding a couple if [ -f foo ]; then cp foo bar ; fi lines to scripts/installer/lay-down-os to copy the appropriate preload archives for system-docker and docker just before rebooting.

joshwget · 2016-12-16T17:59:56Z

What do you think about moving runInstall and associated functions to a top-level installer package?

joshwget · 2016-12-16T19:04:43Z

cmd/control/install.go

+	}
+	log.Debugf("installRancher done")
+
+	//unused by us? :)


This is used for the --kexec flag for upgrading (https://github.com/rancher/os/blob/master/cmd/control/os.go#L54). Hopefully available for standard installs at some point too #1292 .

joshwget · 2016-12-16T19:05:28Z

Is the image embedded in the ISO going to be the same image used for upgrades?

joshwget · 2016-12-16T19:06:25Z

Oops, wrong button 😄

joshwget · 2016-12-16T19:11:44Z

cmd/control/install.go

+	return nil
+}
+
+// files is an array of 'sourcefile:destination' - but i've not seen any examples of it being used.


Probably just historical. I vote to remove it 😄

thaJeztah · 2016-12-16T19:27:14Z

Dockerfile.dapper

        gccgo \
        genisoimage \
+	gettext \
        git \


👋 may want to check your editor settings; looks like all new lines use tabs, but the existing file uses spaces (here and other files

I hate spaces 🗡
tabs forever !!!!

Have you been talking with tianon?

I thought tianon preferred spaces 📦

joshwget · 2016-12-16T19:40:10Z

util/cutil.go

 	"errors"
 )

+// ResolveDevice this isn't reliable - blkid -L LABEL works more often :(


This is really important if it's true in general and we should investigate it. We use this function to resolve LABEL=RANCHER_STATE during boot. Where did these problems occur? Are you sure you weren't using a /dev that didn't match the host /dev?

I'm assuming that blkid is just a thin CLI around libblkid. Maybe this has to do with the versions of libblkid then. util.ResolveDevice uses libblkid from https://github.com/rancher/os/blob/master/Dockerfile.dapper#L16, whereas the blkid binary will be using libblkid from buildroot.

joshwget · 2016-12-16T19:49:17Z

scripts/isolinux.cfg

+INCLUDE ../global.cfg
+
+# each INCLUDEd file has a `DEFAULT mylabel` in it, and the last one wins
+INCLUDE ../linux-previous.cfg


Shouldn't we leave isolinux.cfg alone? rancher.autologin=tty1 rancher.autologin=ttyS0 is getting removed here and we don't really need current/previous when booting from ISO.

what I want to do is use the same kernel&initrd cfg file for both iso and installed boot - and I am thinking of using previous on the iso as the recovery option

We set the autologin parameter on the ISO though, so I'm not sure how we'd share the config. I don't think I understand the recovery part either - why would an ISO have a recovery option?

SvenDowideit · 2016-12-16T22:44:31Z

@tylert dare you to make a PR with your preload changes - yes, it'll get re-written in this PR, but it'll save me some time :)

tylert · 2016-12-16T23:24:31Z

No prob. I will try to get it done this weekend.

SvenDowideit · 2016-12-16T23:53:22Z

@joshwget yeah, I think I'll defer refactoring until 0.9 though, I'm still not finished, and wanted to have an rc with it in already :/

joshwget · 2016-12-17T00:15:52Z

cmd/control/os.go

 				cli.BoolFlag{
 					Name:  "stage, s",
-					Usage: "Only stage the new upgrade, don't apply it",
+					Usage: "Only stage the new upgrade, don't apply it (ie, create the service, pull the image, then exit - upgrade will happen on next reboot?)",


Doesn't upgrade on next boot. Can you take out the second half of this?

so when does it upgrade?

When you run ros os upgrade next. You'd just avoid the image pull by staging.

joshwget · 2016-12-17T00:19:28Z

scripts/run-common

 TTYCONS=${ttycons["${ARCH}"]}

-DEFAULT_KERNEL_ARGS="quiet rancher.password=rancher console=${TTYCONS} rancher.autologin=${TTYCONS}"
+DEFAULT_KERNEL_ARGS="rancher.debug=true rancher.password=rancher console=${TTYCONS} rancher.autologin=${TTYCONS}"


yeah - it helps debug the weirdness - without bothering people at release time

Signed-off-by: Sven Dowideit <[email protected]>

…ller is easier Signed-off-by: Sven Dowideit <[email protected]>

…some details that will delay it Signed-off-by: Sven Dowideit <[email protected]>

Signed-off-by: Sven Dowideit <[email protected]>

….. the iso only has the smaller os-installer image in it \o/ Signed-off-by: Sven Dowideit <[email protected]>

Signed-off-by: Sven Dowideit <[email protected]>

…alling Signed-off-by: Sven Dowideit <[email protected]>

Signed-off-by: Sven Dowideit <[email protected]>

…r now Signed-off-by: Sven Dowideit <[email protected]>

…ked up latest works \o/ Signed-off-by: Sven Dowideit <[email protected]>

Signed-off-by: Sven Dowideit <[email protected]>

SvenDowideit · 2017-01-16T00:51:11Z

the dhcp test failure was due to buildroot 2016.11 - which I've reverted.

now working to figure out why the TestUpgrade goes boom

----------------------------------------------------------------------
1858s
3464
FAIL: upgrade_test.go:9: QemuSuite.TestUpgrade
1858s
3466
upgrade_test.go:18:
1858s
3467
    s.CheckCall(c, "sudo ros -v | grep v0.5.0")
1858s
3468
common_test.go:151:
1858s
3469
    c.Assert(err, IsNil)
1858s
3470
... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc420421bc0), Stderr:[]uint8(nil)} ("exit status 1")

Signed-off-by: Sven Dowideit <[email protected]>

SvenDowideit · 2017-01-16T03:35:44Z

OK, tests pass, I'm going to merge, and then continue work in new PR's, and hopefully mostly after 0.8.0rc3

SvenDowideit changed the title ~~Convert installer to go~~ WIP: Convert installer to go Dec 7, 2016

joshwget reviewed Dec 9, 2016

View reviewed changes

This was referenced Dec 13, 2016

GPT partition option #1448

Merged

remove old installer code #1462

Closed

Instructions to build iso with preloaded images unclear #1449

Open

SvenDowideit force-pushed the convert-installer-to-go branch from 6bfef01 to e7b0558 Compare December 15, 2016 01:54

SvenDowideit force-pushed the convert-installer-to-go branch from e7b0558 to cd35087 Compare December 15, 2016 04:58

SvenDowideit added this to the v0.8.0 milestone Dec 15, 2016

tylert reviewed Dec 15, 2016

View reviewed changes

SvenDowideit force-pushed the convert-installer-to-go branch 2 times, most recently from 43608c9 to aa0c6ad Compare December 16, 2016 12:03

tylert reviewed Dec 16, 2016

View reviewed changes

joshwget reviewed Dec 16, 2016

View reviewed changes

joshwget closed this Dec 16, 2016

joshwget reopened this Dec 16, 2016

joshwget reviewed Dec 16, 2016

View reviewed changes

thaJeztah reviewed Dec 16, 2016

View reviewed changes

joshwget reviewed Dec 16, 2016

View reviewed changes

joshwget reviewed Dec 17, 2016

View reviewed changes

tylert mentioned this pull request Dec 21, 2016

Add preload magic to lay-down-os SvenDowideit/os#1

Closed

SvenDowideit force-pushed the convert-installer-to-go branch 4 times, most recently from 5ead9cb to b2bc5db Compare January 13, 2017 05:10

joshwget and others added 18 commits January 15, 2017 23:39

Wait for device partitions in type-0 Packet instance installs

19e8c84

Run bootstrap services even if autoformat isn't set

4155dee

Allow question marks in unquoted kernel parameters

80820e6

Convert install script to go

087bc6f

Signed-off-by: Sven Dowideit <[email protected]>

make the iso run also get the ssh and cloud-init so testing the insta…

cc78ff7

…ller is easier Signed-off-by: Sven Dowideit <[email protected]>

Started separating out the kernel modules from initrd, but there are …

f5193d0

…some details that will delay it Signed-off-by: Sven Dowideit <[email protected]>

can't work yet - need the host fs to have the iso mounted...

47eaf2b

Signed-off-by: Sven Dowideit <[email protected]>

previous&current isolinux/syslinux cfg works for fresh install, and .…

85bdaa6

….. the iso only has the smaller os-installer image in it \o/ Signed-off-by: Sven Dowideit <[email protected]>

make ros install --append work

1a0e818

Signed-off-by: Sven Dowideit <[email protected]>

quieten the debug messages for install, fix pre-0.8.0-rc2 installer c…

d90217a

…alling Signed-off-by: Sven Dowideit <[email protected]>

the os-installer base Dockerfile

6503928

Signed-off-by: Sven Dowideit <[email protected]>

port the use of parted to go

11e7889

Signed-off-by: Sven Dowideit <[email protected]>

add integration tests for iso boot, install and then boot from disk.

f5230f1

Signed-off-by: Sven Dowideit <[email protected]>

try to simplify logging

7519325

Signed-off-by: Sven Dowideit <[email protected]>

Add isolinux cfg files to installer, and add ros to base installer fo…

bdb0d32

…r now Signed-off-by: Sven Dowideit <[email protected]>

Installing 0.7.1, and then rebooting, and doing a ros upgrade to a fa…

2a57583

…ked up latest works \o/ Signed-off-by: Sven Dowideit <[email protected]>

start testing the version number of our install/upgrade test

6bbed5f

Signed-off-by: Sven Dowideit <[email protected]>

make --fresh apply to the second disk too

e5a7889

Signed-off-by: Sven Dowideit <[email protected]>

SvenDowideit force-pushed the convert-installer-to-go branch from b2bc5db to e5a7889 Compare January 15, 2017 23:43

SvenDowideit added 2 commits January 16, 2017 12:37

fix create-installer to use the installer tarball in the iso

edb8022

Signed-off-by: Sven Dowideit <[email protected]>

disable the old upgrade test - it can't work as things are

4f1418d

Signed-off-by: Sven Dowideit <[email protected]>

SvenDowideit changed the title ~~WIP: Convert installer to go~~ Convert installer to go Jan 16, 2017

SvenDowideit merged commit 29fc463 into rancher:master Jan 16, 2017

SvenDowideit mentioned this pull request Jan 17, 2017

Create an iso that includes installer image so no internet would be required #1112

Closed

Convert installer to go #1456

Convert installer to go #1456

Uh oh!

Conversation

SvenDowideit commented Dec 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SvenDowideit commented Dec 15, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tylert commented Dec 16, 2016

Uh oh!

joshwget commented Dec 16, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joshwget commented Dec 16, 2016

Uh oh!

joshwget commented Dec 16, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SvenDowideit commented Dec 16, 2016

Uh oh!

tylert commented Dec 16, 2016 via email

Uh oh!

SvenDowideit commented Dec 16, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SvenDowideit commented Jan 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SvenDowideit commented Dec 7, 2016 •

edited

Loading

SvenDowideit commented Jan 16, 2017 •

edited

Loading