Repository navigation
fix(ruby): send required source_id when creating a relationship - #492
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
CreateRelationshipRequest requires `source_id` (no serde default), so the Ruby SDK's RelationshipService#create, which never sent it, failed every request. Add `source_id:` (default "manual_entry", the value the server documents for manual entries) and an optional `weight:`. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ruby
RelationshipService#createnever sendssource_id, whichCreateRelationshipRequest(relationships_types.rs) requires with no serde default, so every create is rejected.Evidence
New
test_create_sends_required_source_idinsdks/ruby/test/unit_test.rb(ruby 4.0.2,/opt/homebrew/opt/ruby/bin/ruby):208 runs, 1361 assertions, 1 failures208 runs, 1362 assertions, 0 failures, 0 errors; the other non-e2e Ruby test files also pass.Change
create(src_id:, tgt_id:, keywords:, description:, source_id: "manual_entry", weight: nil);weightis only sent when given.Verified / not verified
lib/edgequake/operations_generated.rb, which is git-ignored (.gitignorelib/rule) and not in the tree; I generated it locally withsdks/tools/sdk_coverage.py's Ruby emitter and did not commit it.Type of change
Checklist
The author checklist items from the template are left for the human submitter to tick.
CI note
Security Auditfails onedgequake-mainitself (CI run 38326709329 at da1831c), and theLayer 1 — Static checksum guardjob failed on the recently merged #446. Neither touches SDK code; I did not investigate them here.