Skip to content

C++17 std::pmr::memory_resource for host_memory_resource #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nirandaperera
Copy link

Description

rmm::mr::host_memory_resource mentions that when rmm uses C++17, it should extend std::pmr::memory_resource interface. This PR adds it, since rmm is on C++17 now.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: niranda perera <[email protected]>
@nirandaperera nirandaperera requested a review from a team as a code owner June 16, 2025 22:42
@nirandaperera nirandaperera requested review from rongou and miscco June 16, 2025 22:42
@nirandaperera nirandaperera marked this pull request as draft June 16, 2025 22:51
Copy link

copy-pr-bot bot commented Jun 16, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@harrism
Copy link
Member

harrism commented Jun 16, 2025

But should we? Now that cuda::memory_resource exists, the strategy may be different. CC @miscco @jrhemstad . @nirandaperera I think this should be discussed in an issue.

Signed-off-by: niranda perera <[email protected]>
@nirandaperera
Copy link
Author

@harrism I see. I was thinking of using the pinned_memory_resource with the std synchronized pool.

@nirandaperera
Copy link
Author

@harrism I opened up an issue here #1961

Signed-off-by: niranda perera <[email protected]>
Signed-off-by: niranda perera <[email protected]>
@github-actions github-actions bot added the CMake label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants