Feature Request: Disable CYW43 debug output

[negentropicdev]

I'm working on firmware for a device that can do host comms both over usb and over wifi as a tcp server.

The CYW43_WARN, _INFO, etc. periodically put stuff out on the usb (via their printf calls) that interferes with the usb communication.

There should be some defines that can disable that capability.

[negentropicdev]

disregard, vscode initially sent me to a different file that didn't have the gating around the macros.

[negentropicdev]

aaaand reopening because I'm unable to figure out a simple way to disable the outputs from build configuration.

[lurch]

Looking at https://github.com/georgerobotics/cyw43-driver/blob/main/src/cyw43_config.h , CYW43_DEBUG, CYW43_INFO and CYW43_WARN are all implemented by calls to CYW43_PRINTF. CYW43_PRINTF is itself declared as

#ifndef CYW43_PRINTF
#include <stdio.h>
#define CYW43_PRINTF(...) printf(__VA_ARGS__)
#endif

so maybe you just need to do something like:

#define CYW43_PRINTF(...) (void)0

? (obviously before you #include any pico-sdk headers)

[kilograham]

see also #2253

[lurch]

...and #2490

[peterharperuk]

Those links are about bluetooth logging. It doesn't really address the fact that CYW43_PRINTF is a bit tricky to disable.
We could add something to our cyw43_configport.h

#ifndef CYW43_PRINTF_ENABLED
#define CYW43_PRINTF_ENABLED 1
#endif

#if !CYW43_PRINTF_ENABLED
#define CYW43_PRINTF(...) (void)0
#endif

Then you just set CYW43_PRINTF_ENABLED=0 to disable all logging from the cyw43 code?

[lurch]

Perhaps people might be surprised that setting CYW43_PRINTF_ENABLED to 0 also stops CYW43_DEBUG, CYW43_INFO and CYW43_WARN from working? (i.e. perhaps we need a "more generic" name than CYW43_PRINTF_ENABLED, e.g. CYW43_LOGGING_ENABLED ? 🤷 )

[peterharperuk]

Yes, CYW43_LOGGING_ENABLED sounds good