Extra param-checking for hardware_pio library (switch asserts to valid_params_if, and add additional checks) #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilograham
previously approved these changes
Feb 25, 2021
|
argh can you rebase |
…d_params_if, and add additional checks)
lurch
force-pushed
the
check_pio_params
branch
from
f9fe434 to
f3333bd
Compare
|
Done 👍 |
kilograham
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little something I knocked up while waiting for a big build to finish 😉
I've checked that
pico-sdkandpico-examplesstill build okay, but I've not actually tried running any of the output binaries on a Pico.