Skip to content

[Beta] docs(cn): translate render-and-commit into Chinese #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 19, 2022
Merged

[Beta] docs(cn): translate render-and-commit into Chinese #686

merged 9 commits into from
Jan 19, 2022
+61 −55

Conversation

oceanlvr
Copy link
Contributor

@oceanlvr oceanlvr commented Dec 8, 2021

No description provided.

@github-actions github-actions bot added the beta label Dec 8, 2021
@oceanlvr
docs(cn): translate render-and-commit into Chinese

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
09da2c1
@oceanlvr oceanlvr changed the title docs: translate render-and-commit into Chinese [Beta] docs(cn): translate render-and-commit into Chinese Dec 8, 2021
@oceanlvr oceanlvr mentioned this pull request Dec 8, 2021
Open
@yyyanghj yyyanghj mentioned this pull request Dec 17, 2021
Closed
KimYangOfCat
KimYangOfCat reviewed Dec 31, 2021
View reviewed changes
Copy link
Contributor

@KimYangOfCat KimYangOfCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻译很好，赞！

@oceanlvr @KimYangOfCat
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
97a827b 
Co-authored-by: Kim Yang <[email protected]>
@oceanlvr
Copy link
Contributor Author

@KimYangOfCat 感谢您的 review，辛苦了～

KimYangOfCat
KimYangOfCat reviewed Dec 31, 2021
View reviewed changes
Neo42
Neo42 reviewed Jan 1, 2022
View reviewed changes
Copy link
Contributor

@Neo42 Neo42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

校对完毕，麻烦处理一下 @oceanlvr

@oceanlvr @KimYangOfCat @Neo42
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ab0dd39 
Co-authored-by: Kim Yang <[email protected]>
Co-authored-by: Hao Jiang ᛋ <[email protected]>
@oceanlvr @Neo42
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fca6cae 
Co-authored-by: Hao Jiang ᛋ <[email protected]>
@oceanlvr
Copy link
Contributor Author

oceanlvr commented Jan 6, 2022 •
edited
Loading

@Neo42 @KimYangOfCat 感谢两位大佬的翻译，特别是 Neo42，指出了大量翻译错误，谢谢你们！

还请麻烦两位大佬看下现在这个版本怎么样了。

@oceanlvr
Apply suggestions from code review

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
b88f274
Neo42
Neo42 reviewed Jan 6, 2022
View reviewed changes
Neo42
Neo42 reviewed Jan 6, 2022
View reviewed changes
@oceanlvr
Apply suggestions from code review

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
75cddbc
Neo42
Neo42 previously approved these changes Jan 6, 2022
View reviewed changes
@oceanlvr
Copy link
Contributor Author

oceanlvr commented Jan 9, 2022

@KimYangOfCat 如果没问题请 approve 这个 PR～

KimYangOfCat
KimYangOfCat previously approved these changes Jan 9, 2022
View reviewed changes
KnowsCount
KnowsCount reviewed Jan 11, 2022
View reviewed changes
@oceanlvr @KnowsCount
Update beta/src/pages/learn/render-and-commit.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5f1902a 
Co-authored-by: KnowsCount <[email protected]>
@oceanlvr oceanlvr dismissed stale reviews from KimYangOfCat and Neo42 via 5f1902a January 11, 2022 11:13
Neo42
Neo42 previously approved these changes Jan 15, 2022
View reviewed changes
TinaaaaP
TinaaaaP reviewed Jan 15, 2022
View reviewed changes
Copy link
Contributor

@TinaaaaP TinaaaaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for the overall flow. Really good translation so far!

@oceanlvr @TinaaaaP
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5ee6f9e 
Co-authored-by: Tina Pu <[email protected]>
@oceanlvr
Update render-and-commit.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4a866ab
@oceanlvr
Copy link
Contributor Author

@QC-L PTAL!

@QC-L QC-L merged commit 9f09ed7 into reactjs:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnowsCount KnowsCount

@TinaaaaP TinaaaaP

@QC-L QC-L

@Neo42 Neo42

@KimYangOfCat KimYangOfCat

Assignees
No one assigned
Labels
beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@oceanlvr @QC-L @Neo42 @KimYangOfCat @KnowsCount @TinaaaaP