Prepare v3 #365
Merged
Prepare v3 #365
+839
−5,185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
qnga
commented
Jul 14, 2023
qnga
commented
- Prefix all resources with readium_
- Remove Ref from the Publication.Context
- Remove ReadingProgression.TTB/BTT/AUTO.
- Remove the Parcelable conformance on Manifest, and deprecate the PublicationRepository.
- Remove all the Activity navigators.
- Remove older settings API.
- Remove the HTTP server.
- Remove highlight.js
qnga
commented
Jul 14, 2023
| @@ -178,8 +161,7 @@ internal class EpubNavigatorViewModel( | |||
| // Serving resources | |||
|
|
|||
| val baseUrl: String = | |||
| baseUrl?.let { it.removeSuffix("/") + "/" } | |||
| ?: publication.linkWithRel("self")?.href | |||
| publication.linkWithRel("self")?.href | |||
| ?: WebViewServer.publicationBaseHref | |||
|
|
|||
There was a problem hiding this comment.
I'm not sure about this. Why should we deal with two different cases?
There was a problem hiding this comment.
We currently support two cases:
- A remote web publication, which will have a
selflink in its manifest pointing to itself on the HTTP server. In this case, we won't use theWebViewServer. - A local publication, e.g. parsed from an EPUB, which won't have any
selflink. In this case the publication is served through theWebViewServer.
mickael-menu
approved these changes
Jul 21, 2023
readium/navigator/src/main/java/org/readium/r2/navigator/epub/EpubSettingsResolver.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.