Skip to content

Realm::convert()'s check for unuploaded changes is incorrect #7966

@sync-by-unito

Description

@sync-by-unito

no_pending_local_changes() checks if there are any untrimmed changesets of local origin, not if there's any unuploaded changesets. Changesets continue to be stored locally after they are uploaded for merging purposes until the server tells us that they are no longer needed, which doesn't always happen at the same time as the upload is acknowledged.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions