-
Notifications
You must be signed in to change notification settings - Fork 32
Adds support for default virtualization storage class #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for default virtualization storage class #2100
Conversation
@@ -133,6 +137,16 @@ export const ReviewAndCreate: React.FC<ReviewAndCreateProps> = ({ | |||
)} | |||
</ListItem> | |||
)} | |||
{deployment === DeploymentType.FULL && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to be consistent with RBD checkbox...
{deployment === DeploymentType.FULL && ( | |
{deployment === DeploymentType.FULL && !hasMultipleClusters && ( |
Signed-off-by: Bipul Adhikari <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test odf-console-e2e-aws |
/cherrypick release-4.19 |
@bipuladh: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cd89ba0
into
red-hat-storage:master
@bipuladh: new pull request created: #2101 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes https://issues.redhat.com/browse/DFBUGS-2481