Skip to content

Adds support for default virtualization storage class #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Jun 2, 2025

@@ -133,6 +137,16 @@ export const ReviewAndCreate: React.FC<ReviewAndCreateProps> = ({
)}
</ListItem>
)}
{deployment === DeploymentType.FULL && (
Copy link
Collaborator

@SanjalKatiyar SanjalKatiyar Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be consistent with RBD checkbox...

Suggested change
{deployment === DeploymentType.FULL && (
{deployment === DeploymentType.FULL && !hasMultipleClusters && (

@SanjalKatiyar
Copy link
Collaborator

/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bipuladh
Copy link
Contributor Author

bipuladh commented Jun 3, 2025

/test odf-console-e2e-aws

@bipuladh
Copy link
Contributor Author

bipuladh commented Jun 3, 2025

/cherrypick release-4.19

@openshift-cherrypick-robot

@bipuladh: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit cd89ba0 into red-hat-storage:master Jun 3, 2025
5 checks passed
@openshift-cherrypick-robot

@bipuladh: new pull request created: #2101

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants