Skip to content

RHSTOR-7460: Upgrade packages in both package.json files #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

RHSTOR-7460: Upgrade packages in both package.json files #2107

merged 1 commit into from
Jun 25, 2025

Conversation

NIKHITHAVADDEMPUDI
Copy link
Collaborator

@NIKHITHAVADDEMPUDI NIKHITHAVADDEMPUDI commented Jun 4, 2025 •
edited
Loading

https://issues.redhat.com/browse/RHSTOR-7210
Remove all the resolutions and upgrade packages, as no vulnerable versions are found by removing resolutions.

The following packages are not upgraded

  1. @openshift-console/dynamic-plugin-sdk: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  2. @openshift-console/dynamic-plugin-sdk-internal: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  3. @openshift-console/dynamic-plugin-sdk-webpack: This is already in latest stable version. Latest one is a prerelease version.

  4. @patternfly/patternfly:

  5. @patternfly/react-charts:

  6. @patternfly/react-code-editor:

  7. @patternfly/react-core:

  8. @patternfly/react-icons:

  9. @patternfly/react-table:

  10. @patternfly/react-tokens:

  11. @patternfly/react-topology: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  12. buffer: This is already in latest version.

  13. cache-loader: This is already in latest version.

  14. circular-dependency-plugin: This is already in latest version.

  15. classnames: This is already in latest version.

  16. css-loader: This is already in latest version.

  17. file-loader: This is already in latest version.

  18. fuzzysearch: This is already in latest version.

  19. i18next-conv: This is already in latest version.

  20. immer: This is already in latest version.

  21. is-ip: This is already in latest version.

  22. js-base64: This is already in latest version.

  23. js-yaml: This is already in latest version.

  24. lodash-es: This is already in latest version.

  25. mobx-react-lite: This is already in latest version.

  26. murmurhash-js: This is already in latest version.

  27. react: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  28. react-copy-to-clipboard: This is already in latest version.(Major version is the latest version).

  29. react-dnd: [email protected] uses type: module in its package.json, making its modules ESM (ECMAScript Modules). This requires fully specified imports, like changing import from 'react/jsx-runtime' to import from 'react/jsx-runtime.js'. React 17 does not have corresponding exports in its package.json that map react/jsx-runtime to react/jsx-runtime.js, leading to errors. React 18 defines these exports, so [email protected] works with React 18 but we are using react 17 currently.

  30. react-dnd-html5-backend: react-dnd-html5-backend 16.0.1 was primarily designed for React 18. It is not fully compatible with React 17.

  31. react-dom:
    react-dom versions 18 and 19 introduce significant changes that are not fully compatible with React 17.
    ReactDOM.render deprecation:
    react-dom 18 deprecates ReactDOM.render and ReactDOM.hydrate. Using these methods will make your application behave like it's running React 17.
    New Root API:
    React 18 introduces a new root API for client rendering using createRoot from react-dom/client. React 17 does not support this API.
    Batching:
    React 18 introduces automatic batching of state updates, which differs from how React 17 handled batching.
    Concurrent Features:
    React 18 includes concurrent features, such as Suspense, that are not present in React 17.

  32. react-dropzone: This is already in latest version.

  33. react-helmet: This is already in latest version.

  34. react-i18next: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  35. react-linkify: This is already in latest stable version.

  36. react-redux: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  37. react-router-dom-v5-compat: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  38. redux: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  39. resolve-url-loader: This is already in latest version.

  40. sass-loader: This is already in latest version.

  41. style-loader: Trying to resolve, the below error on upgradation

  42. thread-loader: This is already in latest version.

  43. ts-loader: This is already in latest version.

  44. typesafe-actions: This is already in latest version.

  45. victory-core: This is already in latest version.

  46. Webpack: Getting errors on upgradation, trying to resolve

  47. webpack-bundle-analyzer: This is already in latest version.

  48. webpack-cli: This is already in latest version.

  49. yup: Getting errors on upgradation, trying to resolve.

  50. @discoveryjs/json-ext: This is already in latest version.

  51. @testing-library/jest-dom: This is already in latest version.

  52. @testing-library/react-hooks: This is already in latest version.

  53. @testing-library/user-event: This is already in latest version.

  54. @types/jest: This is already in latest version.

  55. @types/lodash-es: This is already in latest version.

  56. @types/react-helmet: This is already in latest version.

  57. @types/react-window: This is already in latest version.

  58. eslint-config-airbnb: This is already in latest version.

  59. eslint-plugin-chai-friendly: This is already in latest version.

  60. eslint-plugin-import: This is already in latest version.

  61. eslint-plugin-jest-dom: This is already in latest version.

  62. eslint-plugin-jsx-a11y: This is already in latest version.

  63. eslint-plugin-mobx: This is already in latest version.

  64. http-server: This is already in latest version.

  65. husky: This is already in latest version.

  66. i18next-parser: This is already in latest version.

  67. identity-obj-proxy: This is already in latest version.

  68. jest: This is already in latest version.

  69. jest-environment-jsdom: This is already in latest version.

  70. jest-silent-reporter: This is already in latest version.

  71. mocha-junit-reporter: This is already in latest version.

  72. mochawesome: This is already in latest version.

  73. stylelint-config-sass-guidelines: This is already in latest version.
    Trying to resolves errors with Webpack, style-loader and yup.
    eslint-plugin-testing-library and mochawesome-merge are not updated because of

warning [email protected]: The engine "pnpm" appears to be invalid.
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=22". Got "20.16.0"
error Found incompatible module.

below are the error files of webpack, style-loader, yup and google doc link for dependency trees of all removed resolution
webpack5999_errors.txt
style_loader_errors.txt
yup_errors.txt
https://docs.google.com/document/d/1ZGkogGpw2T4-bElSvJ0cO6W2NRFGH5bNMjwwS2Dj4Jw/edit?usp=sharing

@NIKHITHAVADDEMPUDI NIKHITHAVADDEMPUDI changed the title Upgrade packages in both package.json files. RHSTOR-7210: Upgrade packages in both package.json files. Jun 4, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid jira ticket of any type label Jun 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 4, 2025 •
edited by openshift-ci bot
Loading

@NIKHITHAVADDEMPUDI: This pull request references RHSTOR-7210 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/RHSTOR-7210
Remove all the resolutions and upgrade packages, as no vulnerable versions are found by removing resolutions.

The following packages are not upgraded

  1. @openshift-console/dynamic-plugin-sdk: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
  2. @openshift-console/dynamic-plugin-sdk-internal: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
  3. @openshift-console/dynamic-plugin-sdk-webpack: This is already in latest stable version. Latest one is a prerelease version.
  4. @patternfly/patternfly:
  5. @patternfly/react-charts:
  6. @patternfly/react-code-editor:
  7. @patternfly/react-core:
  8. @patternfly/react-icons:
  9. @patternfly/react-table:
  10. @patternfly/react-tokens: 

  11. @patternfly/react-topology: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  12. buffer:  This is already in latest version.

  13. cache-loader: This is already in latest version.

  14. circular-dependency-plugin: This is already in latest version.

  15. classnames: This is already in latest version.

  16. css-loader: This is already in latest version.

  17. file-loader: This is already in latest version.

  18. fuzzysearch: This is already in latest version.

  19. i18next-conv: This is already in latest version.

  20. immer: This is already in latest version.

  21. is-ip: This is already in latest version.

  22. js-base64: This is already in latest version.

  23. js-yaml: This is already in latest version.

  24. lodash-es: This is already in latest version.

  25. mobx-react-lite: This is already in latest version.

  26. murmurhash-js: This is already in latest version.

  27. react: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  28. react-copy-to-clipboard: This is already in latest version.(Major version is the latest version).

  29. react-dnd:  [email protected] uses type: module in its package.json, making its modules ESM (ECMAScript Modules). This requires fully specified imports, like changing import from 'react/jsx-runtime' to import from 'react/jsx-runtime.js'. React 17 does not have corresponding exports in its package.json that map react/jsx-runtime to react/jsx-runtime.js, leading to errors. React 18 defines these exports, so [email protected] works with React 18  but we are using react 17 currently.

  30. react-dnd-html5-backend: react-dnd-html5-backend 16.0.1 was primarily designed for React 18. It is not fully compatible with React 17.

  31. react-dom:

react-dom versions 18 and 19 introduce significant changes that are not fully compatible with React 17.
ReactDOM.render deprecation:
react-dom 18 deprecates ReactDOM.render and ReactDOM.hydrate. Using these methods will make your application behave like it's running React 17.
New Root API:
React 18 introduces a new root API for client rendering using createRoot from react-dom/client. React 17 does not support this API.
Batching:
React 18 introduces automatic batching of state updates, which differs from how React 17 handled batching.
Concurrent Features:
React 18 includes concurrent features, such as Suspense, that are not present in React 17.
32. react-dropzone: This is already in latest version.
33. react-helmet: This is already in latest version.
34. react-i18next: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
35. react-linkify: This is already in latest stable version.
36. react-redux: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
37. react-router-dom-v5-compat: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
38. redux: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
39. resolve-url-loader: This is already in latest version.
40. sass-loader: This is already in latest version.
41. style-loader: Trying to resolve, the below error on upgradation
ERROR in ./packages/ocs/style.scss
Module build failed (from ./node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 3)
loaderContext.utils.contextify is not a function
at stringifyRequest (/Users/vaddempudinikhitha/Desktop/red_hat/odf-console/node_modules/style-loader/dist/utils.js:28:45)
at getImportStyleAPICode (/Users/vaddempudinikhitha/Desktop/red_hat/odf-console/node_modules/style-loader/dist/utils.js:39:22)
at Object.pitch (/Users/vaddempudinikhitha/Desktop/red_hat/odf-console/node_modules/style-loader/dist/index.js:124:42)
@ ./packages/ocs/storage-class/sc-form.tsx 31:0-23
@ container entry

  1. thread-loader: This is already in latest version.

  2. ts-loader: This is already in latest version.

  3. typesafe-actions: This is already in latest version.

  4. victory-core: This is already in latest version.

  5. Webpack: Getting errors on upgradation, trying to resolve

  6. webpack-bundle-analyzer: This is already in latest version.

  7. webpack-cli: This is already in latest version.

  8. yup: Getting errors on upgradation, trying to resolve.

[webpack-cli] TypeError: The 'compilation' argument must be an instance of Compilation
at NormalModule.getCompilationHooks (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/@openshift-console/dynamic-plugin-sdk-webpack/node_modules/webpack/lib/NormalModule.js:261:10)
at (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/src/webpack/ConsoleRemotePlugin.ts:461:28)
at Hook.eval [as call] (eval at create (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/tapable/lib/HookCodeFactory.js:19:10), :11:1)
at Hook.CALL_DELEGATE [as _call] (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/tapable/lib/Hook.js:14:14)
at Compiler.newCompilation (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/webpack/lib/Compiler.js:1272:30)
at /Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/webpack/lib/Compiler.js:1317:29
at Hook.eval [as callAsync] (eval at create (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/tapable/lib/HookCodeFactory.js:33:10), :6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/tapable/lib/Hook.js:18:14)
at Compiler.compile (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/webpack/lib/Compiler.js:1312:28)
at /Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/webpack/lib/Compiler.js:593:12
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.

  1. @discoveryjs/json-ext: This is already in latest version.
  2. @testing-library/jest-dom: This is already in latest version.
  3. @testing-library/react-hooks: This is already in latest version.
  4. @testing-library/user-event: This is already in latest version.
  5. @types/jest: This is already in latest version.
  6. @types/lodash-es: This is already in latest version.
  7. @types/react-helmet: This is already in latest version.
  8. @types/react-window: This is already in latest version.
  9. eslint-config-airbnb: This is already in latest version.
  10. eslint-plugin-chai-friendly: This is already in latest version.

  11. eslint-plugin-import: This is already in latest version.

  12. eslint-plugin-jest-dom: This is already in latest version.

  13. eslint-plugin-jsx-a11y: This is already in latest version.

  14. eslint-plugin-mobx: This is already in latest version.

  15. http-server: This is already in latest version.

  16. husky: This is already in latest version.

  17. i18next-parser: This is already in latest version.

  18. identity-obj-proxy: This is already in latest version.

  19.  jest: This is already in latest version.

  20.  jest-environment-jsdom: This is already in latest version.

  21.  jest-silent-reporter: This is already in latest version.

  22.  mocha-junit-reporter: This is already in latest version.

  23.  mochawesome: This is already in latest version.

  24.  stylelint-config-sass-guidelines: This is already in latest version.

Trying to resolves errors with Webpack, style-loader and yup.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@SanjalKatiyar
Copy link
Collaborator

SanjalKatiyar commented Jun 5, 2025 •
edited by openshift-ci bot
Loading

/retitle RHSTOR-7460: Upgrade packages in both package.json files

@openshift-ci openshift-ci bot changed the title RHSTOR-7210: Upgrade packages in both package.json files. RHSTOR-7460: Upgrade packages in both package.json files Jun 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2025 •
edited by openshift-ci bot
Loading

@NIKHITHAVADDEMPUDI: This pull request references RHSTOR-7460 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/RHSTOR-7210
Remove all the resolutions and upgrade packages, as no vulnerable versions are found by removing resolutions.

The following packages are not upgraded

  1. @openshift-console/dynamic-plugin-sdk: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
  2. @openshift-console/dynamic-plugin-sdk-internal: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
  3. @openshift-console/dynamic-plugin-sdk-webpack: This is already in latest stable version. Latest one is a prerelease version.
  4. @patternfly/patternfly:
  5. @patternfly/react-charts:
  6. @patternfly/react-code-editor:
  7. @patternfly/react-core:
  8. @patternfly/react-icons:
  9. @patternfly/react-table:
  10. @patternfly/react-tokens: 

  11. @patternfly/react-topology: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  12. buffer:  This is already in latest version.

  13. cache-loader: This is already in latest version.

  14. circular-dependency-plugin: This is already in latest version.

  15. classnames: This is already in latest version.

  16. css-loader: This is already in latest version.

  17. file-loader: This is already in latest version.

  18. fuzzysearch: This is already in latest version.

  19. i18next-conv: This is already in latest version.

  20. immer: This is already in latest version.

  21. is-ip: This is already in latest version.

  22. js-base64: This is already in latest version.

  23. js-yaml: This is already in latest version.

  24. lodash-es: This is already in latest version.

  25. mobx-react-lite: This is already in latest version.

  26. murmurhash-js: This is already in latest version.

  27. react: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  28. react-copy-to-clipboard: This is already in latest version.(Major version is the latest version).

  29. react-dnd:  [email protected] uses type: module in its package.json, making its modules ESM (ECMAScript Modules). This requires fully specified imports, like changing import from 'react/jsx-runtime' to import from 'react/jsx-runtime.js'. React 17 does not have corresponding exports in its package.json that map react/jsx-runtime to react/jsx-runtime.js, leading to errors. React 18 defines these exports, so [email protected] works with React 18  but we are using react 17 currently.

  30. react-dnd-html5-backend: react-dnd-html5-backend 16.0.1 was primarily designed for React 18. It is not fully compatible with React 17.

  31. react-dom:

react-dom versions 18 and 19 introduce significant changes that are not fully compatible with React 17.
ReactDOM.render deprecation:
react-dom 18 deprecates ReactDOM.render and ReactDOM.hydrate. Using these methods will make your application behave like it's running React 17.
New Root API:
React 18 introduces a new root API for client rendering using createRoot from react-dom/client. React 17 does not support this API.
Batching:
React 18 introduces automatic batching of state updates, which differs from how React 17 handled batching.
Concurrent Features:
React 18 includes concurrent features, such as Suspense, that are not present in React 17.
32. react-dropzone: This is already in latest version.
33. react-helmet: This is already in latest version.
34. react-i18next: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
35. react-linkify: This is already in latest stable version.
36. react-redux: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
37. react-router-dom-v5-compat: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
38. redux: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
39. resolve-url-loader: This is already in latest version.
40. sass-loader: This is already in latest version.
41. style-loader: Trying to resolve, the below error on upgradation
ERROR in ./packages/ocs/style.scss
Module build failed (from ./node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 3)
loaderContext.utils.contextify is not a function
at stringifyRequest (/Users/vaddempudinikhitha/Desktop/red_hat/odf-console/node_modules/style-loader/dist/utils.js:28:45)
at getImportStyleAPICode (/Users/vaddempudinikhitha/Desktop/red_hat/odf-console/node_modules/style-loader/dist/utils.js:39:22)
at Object.pitch (/Users/vaddempudinikhitha/Desktop/red_hat/odf-console/node_modules/style-loader/dist/index.js:124:42)
@ ./packages/ocs/storage-class/sc-form.tsx 31:0-23
@ container entry

  1. thread-loader: This is already in latest version.

  2. ts-loader: This is already in latest version.

  3. typesafe-actions: This is already in latest version.

  4. victory-core: This is already in latest version.

  5. Webpack: Getting errors on upgradation, trying to resolve

  6. webpack-bundle-analyzer: This is already in latest version.

  7. webpack-cli: This is already in latest version.

  8. yup: Getting errors on upgradation, trying to resolve.

[webpack-cli] TypeError: The 'compilation' argument must be an instance of Compilation
at NormalModule.getCompilationHooks (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/@openshift-console/dynamic-plugin-sdk-webpack/node_modules/webpack/lib/NormalModule.js:261:10)
at (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/src/webpack/ConsoleRemotePlugin.ts:461:28)
at Hook.eval [as call] (eval at create (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/tapable/lib/HookCodeFactory.js:19:10), :11:1)
at Hook.CALL_DELEGATE [as _call] (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/tapable/lib/Hook.js:14:14)
at Compiler.newCompilation (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/webpack/lib/Compiler.js:1272:30)
at /Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/webpack/lib/Compiler.js:1317:29
at Hook.eval [as callAsync] (eval at create (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/tapable/lib/HookCodeFactory.js:33:10), :6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/tapable/lib/Hook.js:18:14)
at Compiler.compile (/Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/webpack/lib/Compiler.js:1312:28)
at /Users/vaddempudinikhitha/Desktop/Update/odf-console/node_modules/webpack/lib/Compiler.js:593:12
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.

  1. @discoveryjs/json-ext: This is already in latest version.
  2. @testing-library/jest-dom: This is already in latest version.
  3. @testing-library/react-hooks: This is already in latest version.
  4. @testing-library/user-event: This is already in latest version.
  5. @types/jest: This is already in latest version.
  6. @types/lodash-es: This is already in latest version.
  7. @types/react-helmet: This is already in latest version.
  8. @types/react-window: This is already in latest version.
  9. eslint-config-airbnb: This is already in latest version.
  10. eslint-plugin-chai-friendly: This is already in latest version.

  11. eslint-plugin-import: This is already in latest version.

  12. eslint-plugin-jest-dom: This is already in latest version.

  13. eslint-plugin-jsx-a11y: This is already in latest version.

  14. eslint-plugin-mobx: This is already in latest version.

  15. http-server: This is already in latest version.

  16. husky: This is already in latest version.

  17. i18next-parser: This is already in latest version.

  18. identity-obj-proxy: This is already in latest version.

  19.  jest: This is already in latest version.

  20.  jest-environment-jsdom: This is already in latest version.

  21.  jest-silent-reporter: This is already in latest version.

  22.  mocha-junit-reporter: This is already in latest version.

  23.  mochawesome: This is already in latest version.

  24.  stylelint-config-sass-guidelines: This is already in latest version.

Trying to resolves errors with Webpack, style-loader and yup.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2025 •
edited by openshift-ci bot
Loading

@NIKHITHAVADDEMPUDI: This pull request references RHSTOR-7460 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/RHSTOR-7210
Remove all the resolutions and upgrade packages, as no vulnerable versions are found by removing resolutions.

The following packages are not upgraded

  1. @openshift-console/dynamic-plugin-sdk: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
  2. @openshift-console/dynamic-plugin-sdk-internal: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
  3. @openshift-console/dynamic-plugin-sdk-webpack: This is already in latest stable version. Latest one is a prerelease version.
  4. @patternfly/patternfly:
  5. @patternfly/react-charts:
  6. @patternfly/react-code-editor:
  7. @patternfly/react-core:
  8. @patternfly/react-icons:
  9. @patternfly/react-table:
  10. @patternfly/react-tokens: 

  11. @patternfly/react-topology: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  12. buffer:  This is already in latest version.

  13. cache-loader: This is already in latest version.

  14. circular-dependency-plugin: This is already in latest version.

  15. classnames: This is already in latest version.

  16. css-loader: This is already in latest version.

  17. file-loader: This is already in latest version.

  18. fuzzysearch: This is already in latest version.

  19. i18next-conv: This is already in latest version.

  20. immer: This is already in latest version.

  21. is-ip: This is already in latest version.

  22. js-base64: This is already in latest version.

  23. js-yaml: This is already in latest version.

  24. lodash-es: This is already in latest version.

  25. mobx-react-lite: This is already in latest version.

  26. murmurhash-js: This is already in latest version.

  27. react: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  28. react-copy-to-clipboard: This is already in latest version.(Major version is the latest version).

  29. react-dnd:  [email protected] uses type: module in its package.json, making its modules ESM (ECMAScript Modules). This requires fully specified imports, like changing import from 'react/jsx-runtime' to import from 'react/jsx-runtime.js'. React 17 does not have corresponding exports in its package.json that map react/jsx-runtime to react/jsx-runtime.js, leading to errors. React 18 defines these exports, so [email protected] works with React 18  but we are using react 17 currently.

  30. react-dnd-html5-backend: react-dnd-html5-backend 16.0.1 was primarily designed for React 18. It is not fully compatible with React 17.

  31. react-dom:

react-dom versions 18 and 19 introduce significant changes that are not fully compatible with React 17.
ReactDOM.render deprecation:
react-dom 18 deprecates ReactDOM.render and ReactDOM.hydrate. Using these methods will make your application behave like it's running React 17.
New Root API:
React 18 introduces a new root API for client rendering using createRoot from react-dom/client. React 17 does not support this API.
Batching:
React 18 introduces automatic batching of state updates, which differs from how React 17 handled batching.
Concurrent Features:
React 18 includes concurrent features, such as Suspense, that are not present in React 17.
32. react-dropzone: This is already in latest version.
33. react-helmet: This is already in latest version.
34. react-i18next: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
35. react-linkify: This is already in latest stable version.
36. react-redux: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
37. react-router-dom-v5-compat: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
38. redux: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
39. resolve-url-loader: This is already in latest version.
40. sass-loader: This is already in latest version.
41. style-loader: Trying to resolve, the below error on upgradation
42. thread-loader: This is already in latest version.
43. ts-loader: This is already in latest version.
44. typesafe-actions: This is already in latest version.
45. victory-core: This is already in latest version.
46. Webpack: Getting errors on upgradation, trying to resolve
47. webpack-bundle-analyzer: This is already in latest version.
48. webpack-cli: This is already in latest version.
49. yup: Getting errors on upgradation, trying to resolve.

  1. @discoveryjs/json-ext: This is already in latest version.
  2. @testing-library/jest-dom: This is already in latest version.
  3. @testing-library/react-hooks: This is already in latest version.
  4. @testing-library/user-event: This is already in latest version.
  5. @types/jest: This is already in latest version.
  6. @types/lodash-es: This is already in latest version.
  7. @types/react-helmet: This is already in latest version.
  8. @types/react-window: This is already in latest version.
  9. eslint-config-airbnb: This is already in latest version.
  10. eslint-plugin-chai-friendly: This is already in latest version.

  11. eslint-plugin-import: This is already in latest version.

  12. eslint-plugin-jest-dom: This is already in latest version.

  13. eslint-plugin-jsx-a11y: This is already in latest version.

  14. eslint-plugin-mobx: This is already in latest version.

  15. http-server: This is already in latest version.

  16. husky: This is already in latest version.

  17. i18next-parser: This is already in latest version.

  18. identity-obj-proxy: This is already in latest version.

  19.  jest: This is already in latest version.

  20.  jest-environment-jsdom: This is already in latest version.

  21.  jest-silent-reporter: This is already in latest version.

  22.  mocha-junit-reporter: This is already in latest version.

  23.  mochawesome: This is already in latest version.

  24.  stylelint-config-sass-guidelines: This is already in latest version.

Trying to resolves errors with Webpack, style-loader and yup.
eslint-plugin-testing-library and mochawesome-merge are not updated because of

warning [email protected]: The engine "pnpm" appears to be invalid.
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=22". Got "20.16.0"
error Found incompatible module.

below are the error files of webpack, style-loader, yup and google doc link for dependency trees of all removed resolution
webpack5999_errors.txt
style_loader_errors.txt
yup_errors.txt
https://docs.google.com/document/d/1ZGkogGpw2T4-bElSvJ0cO6W2NRFGH5bNMjwwS2Dj4Jw/edit?usp=sharing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@NIKHITHAVADDEMPUDI NIKHITHAVADDEMPUDI force-pushed the branch_2 branch 3 times, most recently from 10abecc to c94f95a Compare June 6, 2025 10:07
SanjalKatiyar
SanjalKatiyar reviewed Jun 10, 2025
View reviewed changes
package.json Outdated
"webpack-bundle-analyzer/ws": "^7.5.10",
"webpack-dev-server/express": "^4.21.0"
},
"resolutions": {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"resolutions": {},

@SanjalKatiyar
Copy link
Collaborator

@NIKHITHAVADDEMPUDI sanity is failing, plz check:

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

@SanjalKatiyar
Copy link
Collaborator

LGTM other than above couple of comments, cc @bipuladh @alfonsomthd.

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

Ok, i will do the above changes, and push again.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 16, 2025 •
edited by openshift-ci bot
Loading

@NIKHITHAVADDEMPUDI: This pull request references RHSTOR-7460 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/RHSTOR-7210
Remove all the resolutions and upgrade packages, as no vulnerable versions are found by removing resolutions.

The following packages are not upgraded

  1. @openshift-console/dynamic-plugin-sdk: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
  2. @openshift-console/dynamic-plugin-sdk-internal: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
  3. @openshift-console/dynamic-plugin-sdk-webpack: This is already in latest stable version. Latest one is a prerelease version.
  4. @patternfly/patternfly:
  5. @patternfly/react-charts:
  6. @patternfly/react-code-editor:
  7. @patternfly/react-core:
  8. @patternfly/react-icons:
  9. @patternfly/react-table:
  10. @patternfly/react-tokens: 

  11. @patternfly/react-topology: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  12. buffer:  This is already in latest version.

  13. cache-loader: This is already in latest version.

  14. circular-dependency-plugin: This is already in latest version.

  15. classnames: This is already in latest version.

  16. css-loader: This is already in latest version.

  17. file-loader: This is already in latest version.

  18. fuzzysearch: This is already in latest version.

  19. i18next-conv: This is already in latest version.

  20. immer: This is already in latest version.

  21. is-ip: This is already in latest version.

  22. js-base64: This is already in latest version.

  23. js-yaml: This is already in latest version.

  24. lodash-es: This is already in latest version.

  25. mobx-react-lite: This is already in latest version.

  26. murmurhash-js: This is already in latest version.

  27. react: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.

  28. react-copy-to-clipboard: This is already in latest version.(Major version is the latest version).

  29. react-dnd:  [email protected] uses type: module in its package.json, making its modules ESM (ECMAScript Modules). This requires fully specified imports, like changing import from 'react/jsx-runtime' to import from 'react/jsx-runtime.js'. React 17 does not have corresponding exports in its package.json that map react/jsx-runtime to react/jsx-runtime.js, leading to errors. React 18 defines these exports, so [email protected] works with React 18  but we are using react 17 currently.

  30. react-dnd-html5-backend: react-dnd-html5-backend 16.0.1 was primarily designed for React 18. It is not fully compatible with React 17.

  31. react-dom:

react-dom versions 18 and 19 introduce significant changes that are not fully compatible with React 17.
ReactDOM.render deprecation:
react-dom 18 deprecates ReactDOM.render and ReactDOM.hydrate. Using these methods will make your application behave like it's running React 17.
New Root API:
React 18 introduces a new root API for client rendering using createRoot from react-dom/client. React 17 does not support this API.
Batching:
React 18 introduces automatic batching of state updates, which differs from how React 17 handled batching.
Concurrent Features:
React 18 includes concurrent features, such as Suspense, that are not present in React 17.
32. react-dropzone: This is already in latest version.
33. react-helmet: This is already in latest version.
34. react-i18next: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
35. react-linkify: This is already in latest stable version.
36. react-redux: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
37. react-router-dom-v5-compat: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
38. redux: All "{ singleton: true, allowFallback: false }" dependencies in odf-console should have same versions as used by OCP console.
39. resolve-url-loader: This is already in latest version.
40. sass-loader: This is already in latest version.
41. style-loader: Trying to resolve, the below error on upgradation
42. thread-loader: This is already in latest version.
43. ts-loader: This is already in latest version.
44. typesafe-actions: This is already in latest version.
45. victory-core: This is already in latest version.
46. Webpack: Getting errors on upgradation, trying to resolve
47. webpack-bundle-analyzer: This is already in latest version.
48. webpack-cli: This is already in latest version.
49. yup: Getting errors on upgradation, trying to resolve.

  1. @discoveryjs/json-ext: This is already in latest version.
  2. @testing-library/jest-dom: This is already in latest version.
  3. @testing-library/react-hooks: This is already in latest version.
  4. @testing-library/user-event: This is already in latest version.
  5. @types/jest: This is already in latest version.
  6. @types/lodash-es: This is already in latest version.
  7. @types/react-helmet: This is already in latest version.
  8. @types/react-window: This is already in latest version.
  9. eslint-config-airbnb: This is already in latest version.
  10. eslint-plugin-chai-friendly: This is already in latest version.

  11. eslint-plugin-import: This is already in latest version.

  12. eslint-plugin-jest-dom: This is already in latest version.

  13. eslint-plugin-jsx-a11y: This is already in latest version.

  14. eslint-plugin-mobx: This is already in latest version.

  15. http-server: This is already in latest version.

  16. husky: This is already in latest version.

  17. i18next-parser: This is already in latest version.

  18. identity-obj-proxy: This is already in latest version.

  19.  jest: This is already in latest version.

  20.  jest-environment-jsdom: This is already in latest version.

  21.  jest-silent-reporter: This is already in latest version.

  22.  mocha-junit-reporter: This is already in latest version.

  23.  mochawesome: This is already in latest version.

  24.  stylelint-config-sass-guidelines: This is already in latest version.

Trying to resolves errors with Webpack, style-loader and yup.
eslint-plugin-testing-library and mochawesome-merge are not updated because of

warning [email protected]: The engine "pnpm" appears to be invalid.
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=22". Got "20.16.0"
error Found incompatible module.

below are the error files of webpack, style-loader, yup and google doc link for dependency trees of all removed resolution
webpack5999_errors.txt
style_loader_errors.txt
yup_errors.txt
https://docs.google.com/document/d/1ZGkogGpw2T4-bElSvJ0cO6W2NRFGH5bNMjwwS2Dj4Jw/edit?usp=sharing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@NIKHITHAVADDEMPUDI NIKHITHAVADDEMPUDI force-pushed the branch_2 branch 5 times, most recently from 92f4e78 to aa1f275 Compare June 16, 2025 11:23
@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

  1. eslint is not upgraded and eslint-plugin-react-hook is kept at version 5.2.0 because compatability issues between these packages leading to errors in sanity checks.
  2. @testing-library/react is not upgraded beacause the sanity checks are failing

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/retest ci/prow/odf-console-e2e-aws

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/retest-required

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

3 similar comments
@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

@NIKHITHAVADDEMPUDI NIKHITHAVADDEMPUDI force-pushed the branch_2 branch 3 times, most recently from ea4f690 to 4cc3e07 Compare June 20, 2025 07:34
@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

3 similar comments
@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/retest

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test ci/prow/images
/test ci/prow/odf-console-e2e-aws

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 23, 2025

@NIKHITHAVADDEMPUDI: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test images

/test odf-console-e2e-aws

Use /test all to run all jobs.

In response to this:

/test ci/prow/images
/test ci/prow/odf-console-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test images

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

2 similar comments
@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

@NIKHITHAVADDEMPUDI
Upgrade packages in both package.json files.
0f473b9 
           Remove all the resolutions and upgrade packages, as no vulnerable versions are found by removing resolutions.
@deepsm007
Copy link

/test odf-console-e2e-aws

1 similar comment
@NIKHITHAVADDEMPUDI
Copy link
Collaborator Author

/test odf-console-e2e-aws

@alfonsomthd
Copy link
Collaborator

/override ci/prow/odf-console-e2e-aws

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 25, 2025

@alfonsomthd: Overrode contexts on behalf of alfonsomthd: ci/prow/odf-console-e2e-aws

In response to this:

/override ci/prow/odf-console-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SanjalKatiyar
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 25, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NIKHITHAVADDEMPUDI, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 84da487 into red-hat-storage:master Jun 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjalKatiyar SanjalKatiyar SanjalKatiyar left review comments

Assignees

@SanjalKatiyar SanjalKatiyar

Labels
approved jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NIKHITHAVADDEMPUDI @openshift-ci-robot @SanjalKatiyar @deepsm007 @alfonsomthd @openshift-merge-robot