[RHSTOR-7189] Implement Multus network isolation acknowledgment flow #2110
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TimothyAsirJeyasing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
TimothyAsirJeyasing
force-pushed
the
epic-7189-enhance-multus
branch
from
4f26b9b to
d242beb
Compare
https://issues.redhat.com/browse/RHSTOR-7189 Signed-off-by: Timothy Asir <[email protected]> Signed-off-by: Timothy Asir Jeyasingh <[email protected]>
TimothyAsirJeyasing
force-pushed
the
epic-7189-enhance-multus
branch
from
d242beb to
0c57d7a
Compare
Please review @SanjalKatiyar , @bipuladh , @alfonsomthd |
|
@TimothyAsirJeyasing: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| {/* Isolate Network Section */} | ||
| <h2 className="odf-section-header odf-mt-lg">{t('Isolate Network')}</h2> | ||
| <div className="odf-indented-section"> |
There was a problem hiding this comment.
In clean code, intentional naming is about your domain (your business concepts, like "Multus"), not formatting details like "indentation".
| <div className="odf-indented-section"> | |
| <div className="odf-multus-section"> |
|
|
||
| {networkType === NetworkType.MULTUS && ( | ||
| <> | ||
| <div className="odf-multus-indent pf-v5-u-mt-md"> |
There was a problem hiding this comment.
| <div className="odf-multus-indent pf-v5-u-mt-md"> | |
| <div className="odf-multus-section__warning pf-v5-u-mt-md"> |
| </Alert> | ||
| </div> | ||
|
|
||
| <div className="odf-multus-indent"> |
There was a problem hiding this comment.
| <div className="odf-multus-indent"> | |
| <div className="odf-multus__ack-checkbox"> |
| description={t( | ||
| 'Multus allows a network seperation between the data operations and the control plane operations.' | ||
| <div className="odf-multus-configuration"> | ||
| {/* Network Section */} |
There was a problem hiding this comment.
| {/* Network Section */} |
| systemNamespace={systemNamespace} | ||
| </Alert> | ||
|
|
||
| {/* Isolate Network Section */} |
There was a problem hiding this comment.
It seems not necessary as the header text already explains it.
| {/* Isolate Network Section */} |
| @@ -17,9 +17,16 @@ import { | |||
| WatchK8sResults, | |||
| } from '@openshift-console/dynamic-plugin-sdk'; | |||
| import { SelectOption } from '@patternfly/react-core/deprecated'; | |||
| import { flatMap } from 'lodash-es'; | |||
There was a problem hiding this comment.
This is unnecessary as we're already importing * as 'lodash-es' in the following line.
https://issues.redhat.com/browse/RHSTOR-7459
This PR implements the enhanced Multus network isolation flow with required user acknowledgment before proceeding. Key changes include:
New UI Components:
Added warning alert with detailed requirements for Multus configuration
Implemented acknowledgment checkbox that must be checked before network selection
Progressive disclosure of network interface dropdowns after acknowledgment
Validation Flow:
Users must explicitly acknowledge running validation tests before configuring networks
Next button remains disabled until both acknowledgment is checked AND networks are selected
Clear visual separation between default pod network and Multus options