Automate key rotation for encrypted RBD storage classes #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch sets the key rotation schedule annotation by default on RBD storage classes created from the UI; enabling automatic key rotation. Signed-off-by: Niraj Yadav <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: black-dragon74 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
black-dragon74
changed the title
|
/retest |
|
@black-dragon74 can u plz add epic/story link to the PR. |
bipuladh
requested changes
Jul 7, 2025
Comment on lines
+40
to
+43
| if ( | ||
| sc?.parameters?.hasOwnProperty('encrypted') && | ||
| sc?.parameters?.['encrypted'] === 'true' | ||
| ) { |
There was a problem hiding this comment.
Please create a function something like isStorageClassEncrypted and use it in L27 & L28 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch sets the key rotation schedule annotation by default on RBD storage classes created from the UI; enabling automatic key rotation.