Update to installation process #2130

bipuladh · 2025-06-25T07:10:14Z

No description provided.

openshift-ci · 2025-06-25T07:10:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alfonsomthd · 2025-06-26T08:54:27Z

packages/odf/components/create-storage-system/EmptyStates/StorageClusterEmptyPage.tsx

+        <EmptyStateFooter>
+          <EmptyStateActions>
+            <Button
+              variant="primary"


Provided we have the ButtonVariant enum, we should use it in all places for code consistency, otherwise there is no point in having such enum (using it in some places and not in others is inconsistent).
A good improvement is to create a custom rule in the linter that detects these attributes without proper enum usage.

alfonsomthd · 2025-06-26T08:56:10Z

packages/odf/modals/ConfigureDF/EmptyStateCreateModal.scss

@@ -0,0 +1,10 @@
+.odf-storage-cluster-create-modal__setup-card {
+  max-width: 25em;


Just to confirm: is em chosen due to parent? em is tied to the parent element while rem is tied to the root.

Adds support for new modal Adds support for redirection to new installation flow Removes deployment type selection in cluster creation wizard Removes external system seleciton flow in cluster creation wizard Signed-off-by: Bipul Adhikari <[email protected]>

alfonsomthd · 2025-07-03T11:58:08Z

packages/odf/components/create-storage-system/EmptyStates/InitialEmptyStatePage.tsx

+    <>
+      <PageHeading title={getPageTitle(location.pathname, t)} />


Suggested change

<>

<PageHeading title={getPageTitle(location.pathname, t)} />

<>

<Helmet>

<title>{getPageTitle(location.pathname, t)}</title>

</Helmet>

<PageHeading title={getPageTitle(location.pathname, t)} />

alfonsomthd · 2025-07-03T12:10:05Z

LGTM. Please add screenshots. @SanjalKatiyar to tag.

openshift-ci · 2025-07-03T12:59:30Z

@bipuladh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/odf-console-e2e-aws	`6bff752`	link	true	`/test odf-console-e2e-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

SanjalKatiyar · 2025-07-07T06:31:26Z

locales/en/plugin__odf-console.json

@@ -580,11 +584,11 @@
  "Data Foundation does not support HDD disks as local devices. Select SSD if you plan to use Data Foundation.": "Data Foundation does not support HDD disks as local devices. Select SSD if you plan to use Data Foundation.",
  "Data Foundation endpoint": "Data Foundation endpoint",
  "Data foundation must be {{version}} or above.": "Data foundation must be {{version}} or above.",
+  "Data Foundation simplifies persistent storage and data services across your cloud-native infrastructure": "Data Foundation simplifies persistent storage and data services across your cloud-native infrastructure",


across your cloud-native infrastructure

isn't this wrong ?? we have non-cloud use cases as well.

even if microcopy is pending, IMO we shouldn't add incorrect text, we will get bugs later otherwise.

SanjalKatiyar · 2025-07-07T06:52:07Z

plugins/odf/console-extensions.json

+    "type": "console.navigation/href",
+    "properties": {
+      "id": "storage-overview",
+      "insertBefore": "odfdashboard",


we won't be having odfdashboard anymore right ?? It's replaced by storage-overview IIUC.

SanjalKatiyar · 2025-07-07T06:53:39Z

plugins/odf/console-extensions.json

+      "id": "storage-object",
+      "insertAfter": "storage-overview",
+      "section": "storage",
+      "name": "%plugin__odf-console~Obejct Storage%",


Suggested change

"name": "%plugin__odf-console~Obejct Storage%",

"name": "%plugin__odf-console~Object Storage%",

SanjalKatiyar · 2025-07-07T06:54:14Z

plugins/odf/console-extensions.json

+    "type": "console.navigation/href",
+    "properties": {
+      "id": "storage-object",
+      "insertAfter": "storage-overview",
+      "section": "storage",
+      "name": "%plugin__odf-console~Obejct Storage%",
+      "href": "/odf/mcg"
+    },
+    "flags": {
+      "required": ["ODF_MODEL", "ODF_ADMIN"]
+    }
+  },


we already have Object storage nav, why add another one ??

SanjalKatiyar · 2025-07-07T06:56:39Z

plugins/odf/console-extensions.json

+      "id": "storage-object",
+      "insertAfter": "storage-overview",
+      "section": "storage",
+      "name": "%plugin__odf-console~Obejct Storage%",


as per current implementation we only show it once rgw/mcg is deployed. do we now need to show always ??

SanjalKatiyar · 2025-07-07T06:57:26Z

plugins/odf/console-extensions.json

+      "insertAfter": "storage-overview",
+      "section": "storage",
+      "name": "%plugin__odf-console~Obejct Storage%",
+      "href": "/odf/mcg"


Suggested change

"href": "/odf/mcg"

"href": "/odf/object-storage"

we have rgw as well, /mcg seems incorrect...

SanjalKatiyar · 2025-07-07T06:58:59Z

packages/odf/modals/ConfigureDF/EmptyStateCreateModal.tsx

+    // eslint-disable-next-line no-console
+    console.log('Redirecting to ', installationFlow);


Suggested change

// eslint-disable-next-line no-console

console.log('Redirecting to ', installationFlow);

SanjalKatiyar · 2025-07-07T06:59:55Z

packages/odf/modals/ConfigureDF/EmptyStateCreateModal.tsx

+        >
+          <CardHeader
+            selectableActions={{
+              onClickAction: redirectTo('storage-cluster'),


Suggested change

onClickAction: redirectTo('storage-cluster'),

onClickAction: redirectTo(StartingPoint.STORAGE_CLUSTER),

similarly at other places...

SanjalKatiyar · 2025-07-07T07:02:01Z

packages/odf/modals/ConfigureDF/EmptyStateCreateModal.tsx

+type DataFoundationInitialCreateModalProps = {
+  closeModal: () => void;
+};
+
+export const StorageClusterCreateModal: React.FC<
+  DataFoundationInitialCreateModalProps


Suggested change

type DataFoundationInitialCreateModalProps = {

closeModal: () => void;

};

export const StorageClusterCreateModal: React.FC<

DataFoundationInitialCreateModalProps

type StorageClusterCreateModalProps = {

closeModal: () => void;

};

export const StorageClusterCreateModal: React.FC<

StorageClusterCreateModalProps

SanjalKatiyar · 2025-07-07T07:04:11Z

packages/odf/modals/ConfigureDF/EmptyStateCreateModal.tsx

+      <ConfigureDFSelections closeModal={closeModal} />
+    </Modal>
+  );
+};


File name is EmptyStateCreateModal.tsx, but there is no component with such name. I think it's good to either rename the file to StorageClusterCreateModal.tsx or rename component to EmptyStateCreateModal.

SanjalKatiyar · 2025-07-07T07:04:56Z

packages/odf/components/create-storage-system/EmptyStates/InitialEmptyStatePage.tsx

+  EmptyStateIcon,
+} from '@patternfly/react-core';
+import { StorageDomainIcon } from '@patternfly/react-icons';
+import { StorageClusterCreateModal } from '../../../modals/ConfigureDF/EmptyStateCreateModal';


nits:

Suggested change

import { StorageClusterCreateModal } from '../../../modals/ConfigureDF/EmptyStateCreateModal';

import { StorageClusterCreateModal } from '@odf/core/modals/ConfigureDF/EmptyStateCreateModal';

SanjalKatiyar · 2025-07-07T07:05:19Z

packages/odf/components/create-storage-system/EmptyStates/InitialEmptyStatePage.tsx

+import { StorageClusterCreateModal } from '../../../modals/ConfigureDF/EmptyStateCreateModal';
+
+const getPageTitle = (path: string, t: TFunction) => {
+  if (path.includes('storage-cluster')) {


Suggested change

if (path.includes('storage-cluster')) {

if (path.includes(StartingPoint.StorageCluster)) {

SanjalKatiyar · 2025-07-07T07:06:08Z

packages/odf/modals/ConfigureDF/util.ts

+  const pathParts = pathname.split('/');
+  const lastPart = pathParts.pop();
+  switch (lastPart) {
+    case 'storage-cluster':


plz use StartingPoint enum...

same for other cases...

SanjalKatiyar · 2025-07-07T07:09:45Z

packages/odf/components/create-storage-system/EmptyStates/InitialEmptyStatePage.tsx

+              <Button
+                variant="link"
+                onClick={() => {
+                  return null;
+                }}
+              >
+                {t('Documentation link')}
+              </Button>


nits: better to not show it at all until we have doc link (if we miss adding link, we will get unnecessary bugs later)... and add a ToDo comment instead...

Suggested change

<Button

variant="link"

onClick={() => {

return null;

}}

>

{t('Documentation link')}

</Button>

alfonsomthd · 2025-07-07T08:23:27Z

plugins/odf/console-extensions.json

+      "id": "storage-object",
+      "insertAfter": "storage-overview",
+      "section": "storage",
+      "name": "%plugin__odf-console~Obejct Storage%",


Suggested change

"name": "%plugin__odf-console~Obejct Storage%",

"name": "%plugin__odf-console~Object Storage%",

openshift-ci bot added the do-not-merge/work-in-progress label Jun 25, 2025

openshift-ci bot added the approved label Jun 25, 2025

alfonsomthd reviewed Jun 26, 2025

View reviewed changes

bipuladh force-pushed the new-install-flow branch from 9a46636 to d75b673 Compare July 3, 2025 05:47

bipuladh changed the title ~~[WIP] Update to installation process~~ Update to installation process Jul 3, 2025

openshift-ci bot removed the do-not-merge/work-in-progress label Jul 3, 2025

bipuladh force-pushed the new-install-flow branch from d75b673 to 6bff752 Compare July 3, 2025 11:46

alfonsomthd reviewed Jul 3, 2025

View reviewed changes

SanjalKatiyar reviewed Jul 7, 2025

View reviewed changes

alfonsomthd reviewed Jul 7, 2025

View reviewed changes

		@@ -0,0 +1,10 @@
		.odf-storage-cluster-create-modal__setup-card {
		max-width: 25em;

		<>
		<PageHeading title={getPageTitle(location.pathname, t)} />

-    <>
-      <PageHeading title={getPageTitle(location.pathname, t)} />
+    <>
+      <Helmet>
+        <title>{getPageTitle(location.pathname, t)}</title>
+      </Helmet>
+      <PageHeading title={getPageTitle(location.pathname, t)} />

	"name": "%plugin__odf-console~Obejct Storage%",
	"name": "%plugin__odf-console~Object Storage%",

		// eslint-disable-next-line no-console
		console.log('Redirecting to ', installationFlow);

	onClickAction: redirectTo('storage-cluster'),
	onClickAction: redirectTo(StartingPoint.STORAGE_CLUSTER),

	import { StorageClusterCreateModal } from '../../../modals/ConfigureDF/EmptyStateCreateModal';
	import { StorageClusterCreateModal } from '@odf/core/modals/ConfigureDF/EmptyStateCreateModal';

	if (path.includes('storage-cluster')) {
	if (path.includes(StartingPoint.StorageCluster)) {

Update to installation process #2130

Are you sure you want to change the base?

Update to installation process #2130

Conversation

bipuladh commented Jun 25, 2025

Uh oh!

openshift-ci bot commented Jun 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alfonsomthd commented Jul 3, 2025

Uh oh!

openshift-ci bot commented Jul 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SanjalKatiyar Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SanjalKatiyar Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SanjalKatiyar Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SanjalKatiyar Jul 7, 2025 •

edited

Loading

SanjalKatiyar Jul 7, 2025 •

edited

Loading

SanjalKatiyar Jul 7, 2025 •

edited

Loading