Fix BlockPool dashboard - mirroring card #2131
Conversation
|
/override ci/prow/odf-console-e2e-aws |
|
@SanjalKatiyar: Overrode contexts on behalf of SanjalKatiyar: ci/prow/odf-console-e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.19 |
|
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| const defaultState = { | ||
| priority: -1, | ||
| health: HealthState.UNKNOWN, | ||
| icon: <GrayUnknownIcon title="Unknown" />, |
There was a problem hiding this comment.
@SanjalKatiyar should Unknown be translated?
There was a problem hiding this comment.
I noticed that, but here: https://github.com/red-hat-storage/odf-console/blob/master/packages/shared/src/dashboards/status-card/states.tsx#L66 also we are not translating.
There was a problem hiding this comment.
We can open a GH issue to fix that.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfonsomthd, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/odf-console-e2e-aws |
|
@SanjalKatiyar: Overrode contexts on behalf of SanjalKatiyar: ci/prow/odf-console-e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 4f4a7de
into
red-hat-storage:master
|
@SanjalKatiyar: new pull request created: #2132 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/DFBUGS-2879