RHSTOR-7462: Upgrade style-loader to 4.0.0 #2138
Conversation
|
@NIKHITHAVADDEMPUDI: This pull request references RHSTOR-7462 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@NIKHITHAVADDEMPUDI: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| "swr": "2.3.3", | ||
| "thread-loader": "^4.0.4", |
There was a problem hiding this comment.
Please don't remove the thread-loader: it'll cause build issues in our CI environment.
If any, style-loader should be removed as it's only for development purposes.
@SanjalKatiyar @bipuladh what about replacing style-loader with mini-css-extract-plugin?
There was a problem hiding this comment.
Please don't remove the thread-loader: it'll cause build issues in our CI environment.
AFAIU removing it shouldn't cause issues in CI env. Earlier "thread-loader" was being used with empty "options" (options: {}), in which case it was over utilising the resources. Removing it entirely might cause a slightly slower build time, but no errors.
If any, style-loader should be removed as it's only for development purposes.
I was not aware that: This loader is primarily meant for development. The default settings are not safe for production environments. So, shifting to mini-css-extract-plugin seems like a good idea !!
There was a problem hiding this comment.
@SanjalKatiyar The improvements I made on that PR were to prevent build errors/timeouts so removing it will imply either consuming more resources (thus having errors like 137) or facing more timeouts.
There was a problem hiding this comment.
I remember, but wasn't that because "thread-loader" was consuming as much resources as it can get for parallel processing (that's why we were limiting worker pool count in the CI env).
If we don't use "thread-loader" at all, we won't be in that situation anymore. However, theoretically build time would increase.
Anyway, I can understand "style-loader" has other issues, so yeah we should remove it.
There was a problem hiding this comment.
Right: my point is that removing the thread-loader will likely cause CI timeouts and slower builds (but keeping it while removing its config will cause resource consumption errors like 137) so let's keep it with the current config.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NIKHITHAVADDEMPUDI The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Will be done as part of: https://issues.redhat.com/browse/RHSTOR-7589 task. |
https://issues.redhat.com/browse/RHSTOR-7462
Upgrade style-loader to 4.0.0
Upradation of style-loader to 4.0.0 is leading to the error:
Module build failed (from ./node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 1)
loaderContext.utils.contextify is not a function
so thread loader is removed from package.json and webpack.config.ts
and upgraded style-loader to 4.0.0
style_loader_errors.txt