manage_vpc_peering: fix integration tests, update role var names #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravesm
reviewed
Jul 13, 2023
Member
gravesm
left a comment
gravesm
left a comment
There was a problem hiding this comment.
Other than the linting error, looks good. Not sure what's going on with the integration tests.
tests/integration/targets/test_manage_vpc_peering/tasks/main.yml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
recheck |
abikouo
requested changes
Jul 26, 2023
tests/integration/targets/test_manage_vpc_peering/defaults/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_manage_vpc_peering/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_manage_vpc_peering/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_manage_vpc_peering/tasks/main.yml
Outdated
Show resolved
Hide resolved
mandar242
changed the title
gravesm
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix integration tests for
manage_vpc_peeringrole.