Add support for vector set commands #1673

StefanPalashev · 2025-06-16T17:41:40Z

Add Support for Redis Vector Set Commands

This Pull Request implements the full suite of Redis Vector Set commands as defined in the Redis documentation, along with unit tests to verify correctness and expected behavior.

The following commands have been implemented:

➕ VADD – Add a new element to a vector set.
🧮 VCARD – Return the number of elements in a vector set.
📏 VDIM – Return the dimensionality of a vector set.
🧬 VEMB – Return the approximate vector associated with a given element in the vector set.
🔍 VGETATTR – Retrieve attribute values associated with an element of a vector set.
ℹ️ VINFO – Return information about a vector set.
🔗 VLINKS – Return the neighbors of a specified element in a vector set.
🎲 VRANDMEMBER – Return one or more random elements from a vector set.
➖ VREM – Remove an element from a vector set.
🛠️ VSETATTR – Associate a JSON object with an element in a vector set.
🧠 VSIM – Return elements similar to a given vector or element.

Command aliases:

❌ VDELATTR - A utility command that can be used to remove the associated attributes of an element in a vector set. It is an alias for VSETATTR with an empty string.

🧪 Tests

Each command is covered by unit tests that verify:

Correct output for valid inputs
Expected behavior for edge cases (e.g., non-existent keys or elements)
Consistency with the Redis vector set specification

The tests serve both as validation and usage examples for future contributors.

nihohit

I still need to go over most of the PR, but moving serde to a non-optional dependency is a no-go. This will have to be made into an optional feature - preferably, the same feature as the JSON module, since I'd like to cut down on the number of features in the crate.
I suggest targetting the 1.0.x branch, and renaming the JSON feature to account for all extra functionality.

.github/workflows/rust.yml

nihohit · 2025-06-16T18:49:51Z

redis/Cargo.toml

-serde = { version = "1.0.219", optional = true }
-serde_json = { version = "1.0.140", optional = true }
+# Needed for RedisJSON Support and vector sets
+serde = { version = "1.0.219" }


please keep those optional. Making these non-optional significantly increases compilation times.

StefanPalashev · 2025-06-16T19:20:09Z

I still need to go over most of the PR, but moving serde to a non-optional dependency is a no-go. This will have to be made into an optional feature - preferably, the same feature as the JSON module, since I'd like to cut down on the number of features in the crate. I suggest targeting the 1.0.x branch, and renaming the JSON feature to account for all extra functionality.

Thank you for the feedback!

Would it make sense to keep the JSON feature separate so it can still be enabled on its own, without pulling in the other extras? I’m happy to consolidate if that’s the preferred direction — just wanted to check in case keeping them separate would offer more flexibility for users.

The target branch will be updated once the other proposed changes are implemented.

nihohit · 2025-06-16T19:43:47Z

It makes sense to introduce this as a separate feature, but this crate uses flag-frenzy to check for potentially problematic feature combinations, which means that introducing new features makes the CI run slower, so I try to avoid that.
I assume you're planning to introduce more Redis 8 features - do they contain more dependencies? how many more of them will require serde or serde_json?

StefanPalashev · 2025-06-17T12:09:01Z

It makes sense to introduce this as a separate feature, but this crate uses flag-frenzy to check for potentially problematic feature combinations, which means that introducing new features makes the CI run slower, so I try to avoid that. I assume you're planning to introduce more Redis 8 features - do they contain more dependencies? how many more of them will require serde or serde_json?

The plan is to implement new Redis 8 features, but based on my understanding, none of the planned additions are expected to introduce dependencies on serde or serde_json.

StefanPalashev · 2025-06-17T15:03:25Z

@nihohit The vector sets feature is now optional. However, if this isn’t quite the approach you had in mind, please feel free to let me know.

redis/src/types.rs

redis/src/lib.rs

- Added support for all Redis vector set commands: - VADD, VCARD, VDIM, VEMB, VGETATTR, VINFO, VLINKS, VRANDMEMBER, VREM, VSETATTR, VSIM - Developed unit tests to verify the correct behavior of each command - Ensured compliance with Redis vector set specifications

These changes improve code clarity and maintainability by eliminating redundant generic type specifications where they are unnecessary.

nihohit

commented on the new functions. Still need to review types and tests.

nihohit · 2025-06-22T12:46:26Z

redis/Cargo.toml

@@ -91,7 +91,7 @@ rustls-native-certs = { version = "0.8", optional = true }
 tokio-rustls = { version = "0.26", optional = true, default-features = false }
 futures-rustls = { version = "0.26", optional = true, default-features = false }

-# Only needed for RedisJSON Support
+# Needed for RedisJSON Support


Needed for modules support

nihohit · 2025-06-22T12:47:02Z

redis/Cargo.toml

@@ -118,6 +118,7 @@ default = ["acl", "streams", "geospatial", "script", "keep-alive", "num-bigint"]
 acl = []
 geospatial = []
 json = ["dep:serde", "serde/derive", "dep:serde_json"]
+vector-sets = ["json"]


why not "dep:serde", "serde/derive", "dep:serde_json"?

nihohit · 2025-06-22T13:01:00Z

redis/src/commands/mod.rs

+    /// [Redis Docs](https://redis.io/commands/VADD)
+    #[cfg(feature = "vector-sets")]
+    #[cfg_attr(docsrs, doc(cfg(feature = "vector-sets")))]
+    fn vadd_extended<K: ToRedisArgs, E: ToRedisArgs>(key: K, input: VectorAddInput<'a>, element: E, options: &'a VAddOptions) -> (bool) {


please be consistent with the naming scheme - we use _options, not _extended.

nihohit · 2025-06-22T13:06:49Z

redis/src/commands/mod.rs

+    /// [Redis Docs](https://redis.io/commands/VEMB)
+    #[cfg(feature = "vector-sets")]
+    #[cfg_attr(docsrs, doc(cfg(feature = "vector-sets")))]
+    fn vemb_raw<K: ToRedisArgs, E: ToRedisArgs>(key: K, element: E) -> Generic {


it's preferable to use an option type here, in case that more values will be added to the command in the future.

nihohit · 2025-06-22T13:09:41Z

redis/src/commands/mod.rs

+    #[cfg_attr(docsrs, doc(cfg(feature = "vector-sets")))]
+    fn vsetattr<K: ToRedisArgs, E: ToRedisArgs, J: Serialize>(key: K, element: E, json_object: &'a J) -> (bool) {
+        let attributes_json = match serde_json::to_value(json_object) {
+            Ok(serde_json::Value::String(s)) if s.is_empty() => "".to_string(),


what happens on the Err case? why not fail then?
Also, why bother with the if s.is_empty() check? what happens if it is removed?

nihohit · 2025-06-22T13:12:15Z

redis/src/commands/mod.rs

+    /// [Redis Docs](https://redis.io/commands/VINFO)
+    #[cfg(feature = "vector-sets")]
+    #[cfg_attr(docsrs, doc(cfg(feature = "vector-sets")))]
+    fn vinfo<K: ToRedisArgs>(key: K) -> Generic {


doesn't this return a HashMap<String, Value>?

nihohit · 2025-06-22T13:25:20Z

redis/src/commands/mod.rs

+    /// [Redis Docs](https://redis.io/commands/VRANDMEMBER)
+    #[cfg(feature = "vector-sets")]
+    #[cfg_attr(docsrs, doc(cfg(feature = "vector-sets")))]
+    fn vrandmember<K: ToRedisArgs>(key: K) -> (Option<Vec<String>>) {


Why return a vec? and why have both this and vrandmember_multiple?

nihohit · 2025-06-22T13:29:12Z

redis/src/commands/mod.rs

+    /// [Redis Docs](https://redis.io/commands/VSIM)
+    #[cfg(feature = "vector-sets")]
+    #[cfg_attr(docsrs, doc(cfg(feature = "vector-sets")))]
+    fn vsim_extended<K: ToRedisArgs>(key: K, input: VectorSimilaritySearchInput<'a>, options: &'a VSimOptions) -> Generic {


again, _options.

nihohit · 2025-06-22T13:30:17Z

redis/src/types.rs

+#[cfg(feature = "vector-sets")]
+#[cfg_attr(docsrs, doc(cfg(feature = "vector-sets")))]
+#[derive(Clone, Copy)]
+pub enum VectorQuantization {


why are these here and not in commands/mod.rs?

nihohit · 2025-06-22T13:30:24Z

redis/src/types.rs

+#[cfg(feature = "vector-sets")]
+#[cfg_attr(docsrs, doc(cfg(feature = "vector-sets")))]
+#[derive(Clone)]
+pub enum EmbeddingInput<'a> {


same for all types below

nihohit reviewed Jun 16, 2025

View reviewed changes

StefanPalashev force-pushed the vector-sets-support branch from 19d0c4c to 77fe7e8 Compare June 17, 2025 14:55

StefanPalashev commented Jun 17, 2025

View reviewed changes

redis/src/types.rs Outdated Show resolved Hide resolved

StefanPalashev commented Jun 17, 2025

View reviewed changes

redis/src/lib.rs Outdated Show resolved Hide resolved

StefanPalashev added 5 commits June 18, 2025 11:45

Remove generic parameters from VADD and VSIM input

9367579

These changes improve code clarity and maintainability by eliminating redundant generic type specifications where they are unnecessary.

Change the matrix configuration for redis 8.0

66dbe37

Make vector set tests compatible with RESP 2 and 3

52300bf

Make the vector sets feature optional

7ca5847

StefanPalashev force-pushed the vector-sets-support branch from 77fe7e8 to 7ca5847 Compare June 18, 2025 08:45

StefanPalashev requested a review from nihohit June 18, 2025 13:36

nihohit reviewed Jun 22, 2025

View reviewed changes

Add support for vector set commands #1673

Are you sure you want to change the base?

Add support for vector set commands #1673

Conversation

StefanPalashev commented Jun 16, 2025

Add Support for Redis Vector Set Commands

🧪 Tests

Uh oh!

nihohit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StefanPalashev commented Jun 16, 2025

Uh oh!

nihohit commented Jun 16, 2025

Uh oh!

StefanPalashev commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StefanPalashev commented Jun 17, 2025

Uh oh!

Uh oh!

Uh oh!

nihohit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StefanPalashev commented Jun 17, 2025 •

edited

Loading