log a warning when validateObject determines the connection is no longer connected and/or the ping fails
#3747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boronia
approved these changes
Feb 28, 2024
|
The reasons for logging in validateObject is quite broad. But I understand and so I have created #3749. As the solution is same, I am not discussing here further and hope you would be satisfied anyway if the solution gets merged. Thanks for using Jedis and being part of the conversation 🙂 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
When
ConnectionFactory.validateObjectis called, the method logs an ERROR level log if the connection to Redis is disconnected and/or the ping fails. This method is called byorg.apache.commons.pool2.impl.GenericObjectPool.evictwhen validating if a connection should be evicted. Because it is expected that the connection may no longer be valid, I suggest we log a WARN instead.As a user of the library, we are getting paged due to our incident monitoring looking for any ERROR log-levels. I alternatively could modify our logging config to filter out this particular log, but I wouldn't want to filter out any future ERROR logs that could be added in the class or package.