Include redis_om package for Poetry 2.0+ compatibility #740
+63
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add redis_om/README.md placeholder so package directory exists - Update .gitignore to track README.md but ignore generated files - Update make_sync.py to preserve README.md when regenerating
- Add redis_om to packages AND include with format=[sdist, wheel] to override .gitignore exclusion - Remove docs/* and images/* from include (shouldn't be in wheels) Fixes all issues from #713: 1. redis_om/ missing from wheel 2. docs/ and images/ incorrectly in wheel 3. python-ulid already updated in prior commit Closes #713 Closes #731
ajGingrich
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes packaging issues with Poetry 2.0+ and wheel builds.
Changes
redis_omto packages inpyproject.toml(from include redis_om package #718 by @dotlambda)redis_om/README.mdandredis_om/__init__.pyplaceholders so the directory exists in git.gitignoreto track placeholder files but ignore generated filesmake_sync.pyto preserve README.md when regeneratingincludewithformat = ["sdist", "wheel"]to override .gitignore and include generatedredis_om/files in wheel buildsdocs/*andimages/*from wheel builds (shouldn't be installed to site-packages)Background
The
redis_om/directory is auto-generated bymake syncfromaredis_om/. Previously it was fully gitignored, but:Wheel Contents Verification
After this fix,
make distproduces a wheel with both packages:aredis_om/- async version (source of truth)redis_om/- sync version (generated)docs/orimages/directories (correctly excluded)Closes #718
Closes #713
Closes #731