Skip to content

Add details to the asyncio connection error message #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2024
Merged

Add details to the asyncio connection error message #3211

merged 2 commits into from
Jul 3, 2024
+19 −1

Conversation

dkuser
Copy link
Contributor

@dkuser dkuser commented Apr 20, 2024 •
edited
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Issue #3209

  • Add details to the asyncio connection error message
  • Add test for asyncio.Connection._error_message

Sorry, something went wrong.

Merge branch 'master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
93eec91
gerzse
gerzse suggested changes Jun 14, 2024
View reviewed changes
@gerzse gerzse mentioned this pull request Jun 14, 2024
Closed
@gerzse gerzse merged commit 57af285 into redis:master Jul 3, 2024
@gerzse gerzse added the maintenance Maintenance (CI, Releases, etc) label Jul 3, 2024
@gerzse gerzse mentioned this pull request Jul 3, 2024
Merged
6 tasks
gerzse pushed a commit to gerzse/redis-py that referenced this pull request Jul 11, 2024
@dkuser @dmitry-kanev
Add details to the asyncio connection error message (redis#3211)
e89cfcc 
For asyncio connection errors, include the details in the error message,
instead of only including the error code.

Co-authored-by: dmitry.kanev <[email protected]>
Co-authored-by: Gabriel Erzse <[email protected]>
gerzse pushed a commit that referenced this pull request Jul 11, 2024
@dkuser @dmitry-kanev @gerzse
Add details to the asyncio connection error message (#3211)
ed1680f 
For asyncio connection errors, include the details in the error message,
instead of only including the error code.

Co-authored-by: dmitry.kanev <[email protected]>
Co-authored-by: Gabriel Erzse <[email protected]>
agnesnatasya pushed a commit to agnesnatasya/redis-py that referenced this pull request Jul 20, 2024
@dkuser @dmitry-kanev @agnesnatasya
Add details to the asyncio connection error message (redis#3211)
1fa726c 
For asyncio connection errors, include the details in the error message,
instead of only including the error code.

Co-authored-by: dmitry.kanev <[email protected]>
Co-authored-by: Gabriel Erzse <[email protected]>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@dkuser @dmitry-kanev @vladvildanov
Add details to the asyncio connection error message (#3211)
0e413a0 
For asyncio connection errors, include the details in the error message,
instead of only including the error code.

Co-authored-by: dmitry.kanev <[email protected]>
Co-authored-by: Gabriel Erzse <[email protected]>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@dkuser @dmitry-kanev @vladvildanov
Add details to the asyncio connection error message (#3211)
22fa2fc 
For asyncio connection errors, include the details in the error message,
instead of only including the error code.

Co-authored-by: dmitry.kanev <[email protected]>
Co-authored-by: Gabriel Erzse <[email protected]>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@dkuser @dmitry-kanev @vladvildanov
Add details to the asyncio connection error message (#3211)
f666258 
For asyncio connection errors, include the details in the error message,
instead of only including the error code.

Co-authored-by: dmitry.kanev <[email protected]>
Co-authored-by: Gabriel Erzse <[email protected]>
Kakadus pushed a commit to Kakadus/redis-py that referenced this pull request Jan 10, 2025
@dkuser @dmitry-kanev @aiven-sal
Add details to the asyncio connection error message (redis#3211)

Verified

This commit was signed with the committer’s verified signature.
aiven-sal Salvatore Mesoraca
GPG key ID: 0567E50A25403074
Verified
Learn about vigilant mode
9f0758a 
For asyncio connection errors, include the details in the error message,
instead of only including the error code.

Co-authored-by: dmitry.kanev <[email protected]>
Co-authored-by: Gabriel Erzse <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gerzse gerzse

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkuser @gerzse @dmitry-kanev