aws_s3: allow empty string as valid object_canned_acl value#4413
aws_s3: allow empty string as valid object_canned_acl value#4413
object_canned_acl value#4413Conversation
|
Commits Review LGTM |
josephwoodward
changed the title
object_canned_acl value
The previous commit fixed the runtime validator to accept "" as a valid object_canned_acl value, but the schema enum field still listed only the SDK canned ACL values. As a result, an explicit `object_canned_acl: ""` in user YAML would trip the schema linter even though the default value of "" was tolerated. Add "" as a valid option and clarify the field description so the schema, the runtime validator, and the writer all agree that an empty value means "do not set an ACL on the upload".
Add unit and integration coverage for object_canned_acl to lock in the agreement between the schema linter, the runtime validator, and the writer. The unit tests exercise both the schema lint path and the config parser for the empty default, explicit empty, valid SDK values, and an invalid value. The integration tests round-trip a valid canned ACL through LocalStack and assert that an invalid value is rejected at stream build time.
|
Commits Review LGTM |
|
Commits Review LGTM |
|
Commits Review LGTM |
2 participants
PR to fix a regression in #4372
The default was changed to "" in to avoid errors on buckets with ACLs disabled, but the config validation was not updated to accept it, causing output initialisation to fail whenever no ACL was configured.