Skip to content

remotion.dev/convert: Show time elapsed #5421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025
Merged

remotion.dev/convert: Show time elapsed #5421

merged 2 commits into from
Jun 19, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 19, 2025

Added elapsed time display to the ConvertProgress component, showing users how long their conversion has been running in mm:ss format.

Changes Made

  • Added formatElapsedTime utility function in packages/convert/app/lib/format-elapsed-time.ts to format elapsed time as mm:ss
  • Enhanced ConvertState type to include startTime and completedTime fields for tracking conversion duration
  • Updated ConvertProgress component to accept and display elapsed time alongside existing progress information
  • Modified ConvertUi component to capture start time when conversion begins and completion time when it finishes

Behavior

  • During conversion: Shows live elapsed time that updates as the conversion progresses
  • After completion: Shows the final elapsed time from when the conversion started to when it finished
  • Format: Time is displayed as mm:ss (e.g., "1:30" for 1 minute 30 seconds, "12:05" for 12 minutes 5 seconds)

The elapsed time appears in the progress section alongside the existing duration and file size information, separated by bullet points for clean visual hierarchy.

Fixes #5086.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copy link

vercel bot commented Jun 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 5:37am
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 5:37am

@Copilot Copilot AI changed the title [WIP] remotion.dev/convert should show time taken @remotion/convert: Add elapsed time display to ConvertProgress component Jun 19, 2025
@Copilot Copilot AI requested a review from JonnyBurger June 19, 2025 05:04
Copilot finished work on behalf of JonnyBurger June 19, 2025 05:04
@JonnyBurger JonnyBurger changed the title @remotion/convert: Add elapsed time display to ConvertProgress component remotion.dev/convert: Show time elapsed Jun 19, 2025
@JonnyBurger JonnyBurger marked this pull request as ready for review June 19, 2025 06:07
@JonnyBurger JonnyBurger merged commit 28a69cb into main Jun 19, 2025
3 checks passed
@JonnyBurger JonnyBurger deleted the copilot/fix-5086 branch June 19, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remotion.dev/convert should show time taken
2 participants