Skip to content

deprecate --note #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2023
Merged

Conversation

N-R-K
Copy link
Collaborator

@N-R-K N-R-K commented May 28, 2023

reasons:

  • The interface is clunky to use
  • Requires Imlib2 to be built with "text" support (which adds additional dependency).
  • It's better done via an actual image editing software
  • No one seems to be using it, since no one objected towards removing it in the discussions thread.

ref: #207
ref: #236

reasons:

* The interface is clunky to use
* Requires Imlib2 to be built with "text" support (which adds additional
  dependency).
* It's better done via an actual image editing software
* No one seems to be using it, since no one objected towards removing it
  in the discussions thread.

ref: resurrecting-open-source-projects#207
ref: resurrecting-open-source-projects#236
src/options.c Outdated
Comment on lines 518 to 521
" [-d SEC] [-e CMD] [-k OPT] [-l STYLE] [-M NUM] [-n OPTS]\n"
" [-d SEC] [-e CMD] [-k OPT] [-l STYLE] [-M NUM]\n"
" [-q NUM] [-s OPTS] [-t % | WxH] [[-F] FILE]\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[-q NUM] [-s OPTS] could be moved to the line above them, that would make it 79 characters long.

Copy link
Collaborator Author

@N-R-K N-R-K May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the output? In the source code it's going to be past 80 char.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the output, yes. Those lines are already above 80 characters in the source code, actually.

The grey vertical bar is on column 81:
2023-05-30-175737_828x189_scrot

Copy link
Collaborator Author

@N-R-K N-R-K May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barely Almost fits into 80chars now.

image

Also since the options now line up in the source itself, considering deleting that comment.

try to keep the source close to 80 char also line up the options a bit
better in the source.
@N-R-K N-R-K merged commit 5f9a2a6 into resurrecting-open-source-projects:master May 30, 2023
@N-R-K N-R-K deleted the notes_rm branch May 30, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants