Skip to content

Conversation

@reubeno
Copy link
Owner

@reubeno reubeno commented Nov 19, 2025

number_prefix is now marked as unmaintained and flagging RUSTSEC errors via cargo deny. Our dependency on this crate is coming through uucore.

Thankfully, the uucore folks are on top of this! They've already merged uutils/coreutils#9322, which replaces use with a maintained crate. Until we can receive that change, we're acknowledging the issue and updating our deny.toml to ignore this specific advisory.

As soon as uucore distributes a new release with this change, Dependabot should flag us to update and we'll update to it and remove this temporary ignore.

@reubeno reubeno force-pushed the number-prefix-error branch from e7b6894 to 7438148 Compare November 19, 2025 17:43
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Test Results

    3 files     23 suites   7m 16s ⏱️
1 132 tests 1 132 ✅ 0 💤 0 ❌
3 376 runs  3 376 ✅ 0 💤 0 ❌

Results for commit 7438148.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 17.32 μs 17.29 μs -0.03 μs ⚪ Unchanged
eval_arithmetic 0.14 μs 0.15 μs 0.00 μs ⚪ Unchanged
expand_one_string 1.74 μs 1.73 μs -0.01 μs ⚪ Unchanged
for_loop 21.63 μs 21.42 μs -0.21 μs ⚪ Unchanged
function_call 2.39 μs 2.33 μs -0.06 μs ⚪ Unchanged
instantiate_shell 58.67 μs 58.22 μs -0.46 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 25954.68 μs 25944.88 μs -9.81 μs ⚪ Unchanged
parse_bash_completion 2084.03 μs 2049.23 μs -34.80 μs 🟢 -1.67%
parse_sample_script 2.17 μs 1.97 μs -0.19 μs 🟢 -8.91%
run_echo_builtin_command 15.61 μs 15.71 μs 0.10 μs ⚪ Unchanged
run_one_external_command 2414.92 μs 2415.28 μs 0.36 μs ⚪ Unchanged
tokenize_sample_script 3.48 μs 3.42 μs -0.06 μs 🟢 -1.78%

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/jobs.rs 🔴 47.71% 🔴 37.16% 🔴 -10.55%
Overall Coverage 🟢 73.76% 🟢 73.62% 🔴 -0.14%

Minimum allowed coverage is 70%, this run produced 73.62%

Test Summary: bash-completion test suite

Outcome Count Percentage
✅ Pass 1344 63.73
❗️ Error 216 10.24
❌ Fail 180 8.53
⏩ Skip 354 16.79
❎ Expected Fail 15 0.71
📊 Total 2109 100.00

@reubeno reubeno enabled auto-merge (squash) November 19, 2025 17:45
@reubeno reubeno merged commit 4fa86d0 into main Nov 19, 2025
43 checks passed
@reubeno reubeno deleted the number-prefix-error branch November 19, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants