Improve scalar result coercion execution errors #5375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds improved handling for `coerce_result` errors which results in more spec compliant errors with `path` and `locations` present.
swalkinshaw
commented
Jun 4, 2025
| expected_error = { | ||
| "message" => "\"bad\" can't be Custom value", | ||
| "locations" => [{"line"=>1, "column"=>3}], | ||
| "path" => ["f2"], |
There was a problem hiding this comment.
Interesting difference here. The input example above (from static validation) includes query in the path and this doesn't.
Looking at the spec, I don't think query should be included? But that's a separate issue (if at all).
There was a problem hiding this comment.
Yeah, query doesn't belong there. Related: #4711
|
Thanks for this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds improved handling for
coerce_resulterrors which results in more spec compliant errors withpathandlocationspresent.Separated out from #5306 because this can be merged more easily.