fix: Cache extend problem

[lee-to]

Description

Cannot bind an instance to a static closure

Summary by CodeRabbit

• Refactor
  • Updated internal implementation to improve how cache extensions are registered. No changes to user-facing features or functionality.

[coderabbitai]

Walkthrough

The update modifies the CacheServiceProvider by removing the static keyword from a closure used in the register method. This change allows the closure to access the $this context of the class. No other logic or structure within the closure or the class has been altered, and no public interfaces or exported entities were changed.

Changes

File	Change Summary
src/Cache/CacheServiceProvider.php	Removed static keyword from closure in register method, allowing closure to access $this.

Poem

In CacheServiceProvider’s gentle care,
A static vanished—now $this is there!
Closures can reach, no longer confined,
To class-bound treasures they now are aligned.
With a hop and a skip, the code feels just right—
A rabbit’s delight in the softest byte! 🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Cache/CacheServiceProvider.php (1)

18-18: Optional: Explicitly declare closure parameters.
Laravel passes the cache manager (and store configuration) into resolver closures. To align with its contract and avoid “too many arguments” warnings, consider declaring the parameters:

Cache::extend('roadrunner', function ($app, array $config = []) {
    $env = Environment::fromGlobals();
    $factory = new Factory(RPC::create($env->getRPCAddress()));
    return Cache::repository(
        new RoadRunnerStore(
            $factory->select(config('roadrunner.cache.storage', 'cache')),
        ),
    );
});

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62677d1 and 48786f6.

📒 Files selected for processing (1)

• src/Cache/CacheServiceProvider.php (1 hunks)

🔇 Additional comments (1)

src/Cache/CacheServiceProvider.php (1)

18-18: Correct removal of static for binding support.
Removing the static keyword from the closure passed to Cache::extend ensures that the closure can be bound to the CacheManager instance at runtime, enabling use of $this or injected services inside the resolver.