-
Notifications
You must be signed in to change notification settings - Fork 43
Adapt w.r.t. coq/coq#16004. #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aba8e19
to
407bf4b
Compare
Not sure what is the policy for older versions. I'm a bit surprised that mathclasses still compiles with 8.6, is this really true? |
I don't recall dropping support for 8.6 to 8.10, but it looks like the nix file only tests from 8.11, which would be fine with me. |
72ae762
to
7a8f515
Compare
I've pushed a patch to be more compatible with older versions, by deactivating the unknown attribute warning. Let's see how it fares, if it compiles up to 8.11 it should be good to go. |
7a8f515
to
9d3fc8e
Compare
Thanks! It works from 8.11. |
OK, so I consider this ready to merge. Deactivating the broken CIs should be performed in its own PR, instead. |
We had dropped compatibility with Coq versions < 8.11 in 8.13.0, but it was reintroduced by a contributor in 8.15.0. It's fine to remove it now. Removing the tests with Coq 8.6-8.10 should amount to reverting #103 (except that there will be a conflict in |
AFAICT even in master these tests are broken. If you look at the output of the CI in this PR, there is already an issue with the Automatic Introduction flag which is unrelated to the patches from here. |
@spitters ping |
Should be backwards compatible.